Skip to content
This repository was archived by the owner on Nov 30, 2023. It is now read-only.

Commit 362b015

Browse files
committed
Small typos and corrections
1 parent 06cb262 commit 362b015

File tree

5 files changed

+5
-7
lines changed

5 files changed

+5
-7
lines changed

containers/docker-existing-docker-compose/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,3 @@ Follow these steps to use it:
4242
Copyright (c) Microsoft Corporation. All rights reserved.
4343

4444
Licensed under the MIT License. See [LICENSE](https://github.com/Microsoft/vscode-dev-containers/blob/master/LICENSE)
45-

containers/docker-in-docker-compose/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ That's it!
4646
There are no special setup steps are required, but note that the included `.devcontainer/Dockerfile` can be altered to work with other Debian/Ubuntu-based container images such as `node` or `python`. Just, update the `FROM` statement to reference the new base image. For example:
4747
4848
```Dockerfile
49-
FROM node:8
49+
FROM node:lts
5050
```
5151
5252
Beyond that, just follow these steps to use the definition:

containers/docker-in-docker/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ That's it!
4747
There are no special setup steps are required, but note that the included `.devcontainer/Dockerfile` can be altered to work with other Debian/Ubuntu-based container images such as `node` or `python`. Just, update the `FROM` statement to reference the new base image. For example:
4848
4949
```Dockerfile
50-
FROM node:8
50+
FROM node:lts
5151
```
5252
5353
Beyond that, just follow these steps to use the definition:

containers/kubernetes-helm/.devcontainer/Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ FROM debian:9
99
# Install git, process tools
1010
RUN apt-get update && apt-get -y install git procps
1111

12-
1312
# Install Docker CE CLI
1413
RUN apt-get install -y apt-transport-https ca-certificates curl gnupg-agent software-properties-common lsb-release \
1514
&& curl -fsSL https://download.docker.com/linux/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/gpg | apt-key add - \

containers/kubernetes-helm/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ You can adapt your own existing development container Dockerfile to support this
2626

2727
```Dockerfile
2828
# Install Docker CE CLI
29-
RUN apt-get install -y apt-transport-https ca-certificates curl gnupg-agent software-properties-common \
29+
RUN apt-get install -y apt-transport-https ca-certificates curl gnupg-agent software-properties-common lsb-release \
3030
&& curl -fsSL https://download.docker.com/linux/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/gpg | apt-key add - \
3131
&& add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/$(lsb_release -is | tr '[:upper:]' '[:lower:]') $(lsb_release -cs) stable" \
3232
&& apt-get update \
@@ -69,7 +69,7 @@ That's it!
6969
There are no special setup steps are required, but note that the included `.devcontainer/Dockerfile` can be altered to work with other Debian/Ubuntu-based container images such as `node` or `python`. Just, update the `FROM` statement to reference the new base image. For example:
7070
7171
```Dockerfile
72-
FROM node:8
72+
FROM node:lts
7373
```
7474
7575
In addition, if you want to **disable sync'ing** local Kubernetes config into the container, remove `"-e", "SYNC_LOCALHOST_KUBECONFIG=true",` from `runArgs` in `.devcontainer/devcontainer.json`.
@@ -95,7 +95,7 @@ Follow the steps below for your operating system to use the definition.
9595
3. Start VS Code and open your project folder.
9696
9797
6. After following step 2 or 3, the contents of the `.devcontainer` folder in your project can be adapted to meet your needs.
98-
98+
9999
7. Finally, press <kbd>F1</kbd> and run **Remote-Containers: Reopen Folder in Container** to start using the definition.
100100
101101
8. [Optional] If you want to use [Helm](https://helm.sh), open a VS Code terminal and run:

0 commit comments

Comments
 (0)