Skip to content
This repository was archived by the owner on Nov 30, 2023. It is now read-only.

Commit 48520ee

Browse files
authored
bump go to 1.19 (#1564)
1 parent fea4c6f commit 48520ee

File tree

7 files changed

+18
-18
lines changed

7 files changed

+18
-18
lines changed

containers/go/.devcontainer/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
# [Choice] Go version (use -bullseye variants on local arm64/Apple Silicon): 1, 1.18, 1.17, 1-bullseye, 1.18-bullseye, 1.17-bullseye, 1-buster, 1.18-buster, 1.17-buster
1+
# [Choice] Go version (use -bullseye variants on local arm64/Apple Silicon): 1, 1.19, 1.18, 1-bullseye, 1.19-bullseye, 1.18-bullseye, 1-buster, 1.19-buster, 1.18-buster
22
ARG VARIANT=1-bullseye
33
FROM mcr.microsoft.com/vscode/devcontainers/go:0-${VARIANT}
44

5-
# [Choice] Node.js version: none, lts/*, 16, 14, 12, 10
5+
# [Choice] Node.js version: none, lts/*, 18, 16, 14
66
ARG NODE_VERSION="none"
77
RUN if [ "${NODE_VERSION}" != "none" ]; then su vscode -c "umask 0002 && . /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"; fi
88

containers/go/.devcontainer/base.Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# [Choice] Go version (use -bullseye variants on local arm64/Apple Silicon): 1, 1.18, 1.17, 1-bullseye, 1.18-bullseye, 1.17-bullseye, 1-buster, 1.18-buster, 1.17-buster
1+
# [Choice] Go version (use -bullseye variants on local arm64/Apple Silicon): 1, 1.19, 1.18, 1-bullseye, 1.19-bullseye, 1.18-bullseye, 1-buster, 1.19-buster, 1.18-buster
22
ARG VARIANT=1-bullseye
33
FROM golang:${VARIANT}
44

@@ -21,7 +21,7 @@ ENV GO111MODULE=auto
2121
RUN bash /tmp/library-scripts/go-debian.sh "none" "/usr/local/go" "${GOPATH}" "${USERNAME}" "false" \
2222
&& apt-get clean -y && rm -rf /var/lib/apt/lists/*
2323

24-
# [Choice] Node.js version: none, lts/*, 16, 14, 12, 10
24+
# [Choice] Node.js version: none, lts/*, 18, 16, 14
2525
ARG NODE_VERSION="none"
2626
ENV NVM_DIR=/usr/local/share/nvm
2727
ENV NVM_SYMLINK_CURRENT=true \

containers/go/.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"build": {
44
"dockerfile": "Dockerfile",
55
"args": {
6-
// Update the VARIANT arg to pick a version of Go: 1, 1.18, 1.17
6+
// Update the VARIANT arg to pick a version of Go: 1, 1.19, 1.18
77
// Append -bullseye or -buster to pin to an OS version.
88
// Use -bullseye variants on local arm64/Apple Silicon.
99
"VARIANT": "1-bullseye",

containers/go/definition-manifest.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,30 @@
11
{
2-
"variants": ["1.18-bullseye", "1.18-buster", "1.17-bullseye", "1.17-buster"],
3-
"definitionVersion": "0.206.3",
2+
"variants": ["1.19-bullseye", "1.19-buster", "1.18-bullseye", "1.18-buster"],
3+
"definitionVersion": "0.207.0",
44
"build": {
5-
"latest": "1.18-bullseye",
5+
"latest": "1.19-bullseye",
66
"rootDistro": "debian",
77
"tags": [
88
"go:${VERSION}-${VARIANT}"
99
],
1010
"architectures": {
11+
"1.19-bullseye": ["linux/amd64", "linux/arm64"],
1112
"1.18-bullseye": ["linux/amd64", "linux/arm64"],
12-
"1.17-bullseye": ["linux/amd64", "linux/arm64"],
13-
"1.18-buster": ["linux/amd64"],
14-
"1.17-buster": ["linux/amd64"]
13+
"1.19-buster": ["linux/amd64"],
14+
"1.18-buster": ["linux/amd64"]
1515
},
1616
"variantTags": {
17-
"1.18-bullseye": [
18-
"go:${VERSION}-1.18",
17+
"1.19-bullseye": [
18+
"go:${VERSION}-1.19",
1919
"go:${VERSION}-1",
2020
"go:${VERSION}-1-bullseye",
2121
"go:${VERSION}-bullseye"
2222
],
23-
"1.18-buster": [
23+
"1.19-buster": [
2424
"go:${VERSION}-1-buster",
2525
"go:${VERSION}-buster"
2626
],
27-
"1.17-bullseye": ["go:${VERSION}-1.17"]
27+
"1.18-bullseye": ["go:${VERSION}-1.18"]
2828
}
2929
},
3030
"dependencies": {

script-library/container-features/src/devcontainer-features.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -772,7 +772,7 @@
772772
"options": {
773773
"version": {
774774
"type": "string",
775-
"proposals": ["latest", "1.18", "1.17"],
775+
"proposals": ["latest", "1.19", "1.18"],
776776
"default": "latest",
777777
"description": "Select or enter a Go version to install"
778778
}

script-library/docs/go.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Or as a feature:
2424

2525
|Argument|Feature option|Default|Description|
2626
|--------|--------------|-------|-----------|
27-
|Go version|`version` | `latest`| Version of Go to install. Use `latest` to install the latest released version. Partial version numbers are accepted (e.g. `1.17`).|
27+
|Go version|`version` | `latest`| Version of Go to install. Use `latest` to install the latest released version. Partial version numbers are accepted (e.g. `1.19`).|
2828
|GOROOT| | `/usr/local/go`| Location to install Go. |
2929
|GOPATH| | `/go`| Location to use as the `GOPATH`. Tools are installed under `${GOPATH}/bin` |
3030
|Non-root user| | `automatic`| Specifies a user in the container other than root. A value of `automatic` will cause the script to check for a user called `vscode`, then `node`, `codespace`, and finally a user with a UID of `1000` before falling back to `root`. |

script-library/test/regression/run-scripts.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ if [ "${DISTRO}" = "debian" ]; then
113113
run_script git-from-src "latest true"
114114
run_script git-lfs "" "2.13.3"
115115
run_script github
116-
run_script go "1.17 /opt/go /go ${USERNAME} false"
116+
run_script go "1.19 /opt/go /go ${USERNAME} false"
117117
run_script gradle "4.4 /usr/local/sdkman1 ${USERNAME} false"
118118
run_script kubectl-helm "latest latest latest"
119119
run_script maven "3.6.3 /usr/local/sdkman3 ${USERNAME} false"

0 commit comments

Comments
 (0)