Util function fix (CI Ignore)

Author: Chuxel

script-library/shared/utils.sh

@@ -1,20 +1,21 @@
-# If in automatic mode, determine if a user already exists, if not use vscode
+# If in automatic mode, determine if a user already exists, if not use root
 detect_user() {
     local user_variable_name=${1:-username}
-    local user_variable_value=${!user_variable_name}
     local possible_users=${2:-("vscode" "node" "codespace" "$(awk -v val=1000 -F ":" '$3==val{print $1}' /etc/passwd)")}
-    if [ "${user_variable_value}" = "auto" ] || [ "${user_variable_value}" = "automatic" ]; then
-        declare -g ${user_variable_name}=vscode
+    if [ "${!user_variable_name}" = "auto" ] || [ "${!user_variable_name}" = "automatic" ]; then
+        declare -g ${user_variable_name}=""
         for current_user in ${possible_users[@]}; do
-            if id -u ${current_user} > /dev/null 2>&1; then
-                declare -g ${user_variable_name}=${current_user}
+            if id -u "${current_user}" > /dev/null 2>&1; then
+                declare -g ${user_variable_name}="${current_user}"
                 break
             fi
         done
-    elif [ "${user_variable_value}" = "none" ] || ! id "${user_variable_value}" > /dev/null 2>&1; then
+    fi
+    if [ "${!user_variable_name}" = "" ] || [ "${!user_variable_name}" = "none" ] || ! id -u "${!user_variable_name}" > /dev/null 2>&1; then
         declare -g ${user_variable_name}=root
     fi
 }
+
 # Use Oryx to install something using a partial version match
 oryx_install() {
     local platform=$1
@@ -240,4 +241,4 @@ apt_cache_version_soft_match() {
     # Use this value as the return value of this function
     declare -g ${variable_name}="=${fuzzy_version}"
     echo "${variable_name}=${!variable_name}"
-}
+}