Merge pull request #792 from dzsquared/dotnetmssql-removesetecho

removes set echo from dotnet-mssql

Author: bamurtaugh

containers/dotnet-mssql/.devcontainer/docker-compose.yml

@@ -7,7 +7,7 @@ services:
       dockerfile: Dockerfile
       args:
         # [Choice] Update 'VARIANT' to pick a .NET Core version: 2.1, 3.1, 5.0
-        VARIANT: 3.1
+        VARIANT: 5.0
         # [Choice] Node.js version: none, lts/*, 16, 14, 12, 10
         NODE_VERSION: "lts/*"
         # [Option] Install Azure CLI

containers/dotnet-mssql/.devcontainer/mssql/installSQLtools.sh

@@ -1,5 +1,4 @@
 #!/bin/bash
-set -echo
 echo "Installing mssql-tools"
 curl -sSL https://packages.microsoft.com/keys/microsoft.asc | (OUT=$(apt-key add - 2>&1) || echo $OUT)
 DISTRO=$(lsb_release -is | tr '[:upper:]' '[:lower:]')

containers/dotnet-mssql/README.md

@@ -141,11 +141,10 @@ This definition includes some test code that will help you verify it is working
 3. Start VS Code, press <kbd>F1</kbd>, and select **Remote-Containers: Open Folder in Container...**
 4. Select the `containers/dotnetcore` folder.
 5. After the folder has opened in the container, if prompted to restore packages in a notification, click "Restore".
-6. After packages are restored, press <kbd>F5</kbd> to start the project.
-7. Once the project is running, press <kbd>F1</kbd> and select **Remote-Containers: Forward Port from Container...**
-8. Select port 8090 and click the "Open Browser" button in the notification that appears.
-9. You should see "Hello remote world from ASP.NET Core!" after the page loads.
-10. From here, you can add breakpoints or edit the contents of the `test-project` folder to do further testing.
+6. After packages are restored, press <kbd>F5</kbd> to start the project. *Note: if Auto Forward Ports has been disabled, you will need to manually forward port 8090 from the container with "Remote-Containers: Forward Ports..."*
+7. Open the browser to [localhost:8090](http://localhost:8090).
+8. You should see "The databases are: ApplicationDB,msdb,model,tempdb,master" after the page loads.
+9. From here, you can add breakpoints or edit the contents of the `test-project` folder to do further testing.
 
 ## License
 

containers/dotnet-mssql/test-project/Program.cs

@@ -17,7 +17,7 @@ public static void Main(string[] args)
             string databaseNames = "";
             SqlConnectionStringBuilder connectionBuilder = new SqlConnectionStringBuilder();
 
-            connectionBuilder.DataSource = "localhost,61433"; 
+            connectionBuilder.DataSource = "localhost,1433"; 
             connectionBuilder.UserID = "sa";            
             connectionBuilder.Password = "P@ssw0rd"; 
             using (SqlConnection containerConnection = new SqlConnection(connectionBuilder.ConnectionString)) {

containers/dotnet-mssql/test-project/aspnetapp.csproj

@@ -1,12 +1,9 @@
 <Project Sdk="Microsoft.NET.Sdk.Web">
-
   <PropertyGroup>
-    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <TargetFramework>netcoreapp5.0</TargetFramework>
     <UserSecretsId>31051026529000467138</UserSecretsId>
   </PropertyGroup>
-
   <ItemGroup>
-    <PackageReference Include="Microsoft.Data.SqlClient" Version="2.0.1" />
+    <PackageReference Include="Microsoft.Data.SqlClient" Version="3.0.0" />
   </ItemGroup>
-
 </Project>