Skip to content
This repository was archived by the owner on Nov 30, 2023. It is now read-only.

Commit 7db43f8

Browse files
committed
placed comments back in and continue with layers that are more optimal as suggested.
1 parent 0aa8765 commit 7db43f8

File tree

2 files changed

+15
-17
lines changed

2 files changed

+15
-17
lines changed

containers/typescript-node-8/.devcontainer/Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ ENV DEBIAN_FRONTEND=noninteractive
1111
# Set the default shell to bash instead of sh
1212
ENV SHELL /bin/bash
1313

14-
1514
RUN apt-get update \
1615
&& apt-get -y install --no-install-recommends apt-utils 2>&1 \
1716
# Verify git and needed tools are installed

containers/typescript-node-lts/.devcontainer/Dockerfile

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -5,33 +5,32 @@
55

66
FROM node:lts
77

8-
# Configure apt
98
ENV DEBIAN_FRONTEND=noninteractive
9+
10+
# Set the default shell to bash instead of sh
11+
ENV SHELL /bin/bash
12+
13+
# Configure apt
1014
RUN apt-get update \
1115
&& apt-get -y install --no-install-recommends apt-utils 2>&1
1216

1317
# Verify git and needed tools are installed
14-
RUN apt-get install -y git procps
15-
16-
# Remove outdated yarn from /opt and install via package
17-
# so it can be easily updated via apt-get upgrade yarn
18-
RUN rm -rf /opt/yarn-* \
18+
RUN apt-get install -y git procps \
19+
# Remove outdated yarn from /opt and install via package
20+
# so it can be easily updated via apt-get upgrade yarn
21+
&& rm -rf /opt/yarn-* \
1922
&& rm -f /usr/local/bin/yarn \
2023
&& rm -f /usr/local/bin/yarnpkg \
2124
&& apt-get install -y curl apt-transport-https lsb-release \
2225
&& curl -sS https://dl.yarnpkg.com/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/pubkey.gpg | apt-key add - 2>/dev/null \
2326
&& echo "deb https://dl.yarnpkg.com/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/ stable main" | tee /etc/apt/sources.list.d/yarn.list \
2427
&& apt-get update \
25-
&& apt-get -y install --no-install-recommends yarn
26-
27-
# Install tslint and typescript
28-
RUN npm install -g tslint typescript
29-
30-
# Clean up
31-
RUN apt-get autoremove -y \
28+
&& apt-get -y install --no-install-recommends yarn \
29+
# Install tslint and typescript
30+
&& npm install -g tslint typescript \
31+
# Clean up
32+
&& apt-get autoremove -y \
3233
&& apt-get clean -y \
3334
&& rm -rf /var/lib/apt/lists/*
34-
ENV DEBIAN_FRONTEND=dialog
3535

36-
# Set the default shell to bash instead of sh
37-
ENV SHELL /bin/bash
36+
ENV DEBIAN_FRONTEND=dialog

0 commit comments

Comments
 (0)