[Static Web Apps] Fix Node.js and Core Tools version mismatch (#1305)

Author: sinedied

containers/azure-static-web-apps/.devcontainer/Dockerfile

@@ -1,18 +1,20 @@
-# Find the Dockerfile for mcr.microsoft.com/azure-functions/python:3.0-python3.8-core-tools at this URL
-# https://github.com/Azure/azure-functions-docker/blob/dev/host/3.0/buster/amd64/python/python38/python38-core-tools.Dockerfile
-FROM mcr.microsoft.com/azure-functions/python:3.0-python3.8-core-tools
+# Find the Dockerfile at this URL
+# https://github.com/Azure/azure-functions-docker/blob/dev/host/4/bullseye/amd64/python/python39/python39-core-tools.Dockerfile
+FROM mcr.microsoft.com/azure-functions/python:4-python3.9-core-tools
 
 # Copy library scripts to execute
 COPY library-scripts/*.sh library-scripts/*.env /tmp/library-scripts/
 
-# Install Node.js and Azure Static Web Apps CLI
-ARG NODE_VERSION="lts/*"
+# Install Node.js, Azure Static Web Apps CLI and Azure Functions Core Tools
+ARG NODE_VERSION="16"
+ARG CORE_TOOLS_VERSION="4"
 ENV NVM_DIR="/usr/local/share/nvm" \
     NVM_SYMLINK_CURRENT=true \
     PATH="${NVM_DIR}/current/bin:${PATH}"
 RUN bash /tmp/library-scripts/node-debian.sh "${NVM_DIR}" "${NODE_VERSION}" "${USERNAME}" \
     && su vscode -c "umask 0002 && . /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1" \
     && su vscode -c "umask 0002 && npm install --cache /tmp/empty-cache -g @azure/static-web-apps-cli" \
+    && if [ $CORE_TOOLS_VERSION != "4" ]; then apt-get remove -y azure-functions-core-tools-4 && apt-get update && apt-get install -y "azure-functions-core-tools-${CORE_TOOLS_VERSION}"; fi \
     && apt-get clean -y && rm -rf /var/lib/apt/lists/*
 
 # [Optional] Uncomment this section to install additional OS packages.

containers/azure-static-web-apps/.devcontainer/devcontainer.json

@@ -3,8 +3,10 @@
 	"build": {
 		"dockerfile": "Dockerfile",
 		"args": {
-			// Options
-			"NODE_VERSION": "lts/*"
+			// Please look at runtime version support to make sure you're using compatible versions
+			// https://docs.microsoft.com/en-us/azure/azure-functions/supported-languages#languages-by-runtime-version
+			"NODE_VERSION": "16",
+			"CORE_TOOLS_VERSION": "4"
 		}
 	},
 	"forwardPorts": [ 7071, 4280 ],