Skip to content
This repository was archived by the owner on Nov 30, 2023. It is now read-only.

Commit a6b4dd0

Browse files
Make nodejs optional as per phoenix 1.6 (#1125)
1 parent 7027468 commit a6b4dd0

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

containers/elixir-phoenix-postgres/.devcontainer/Dockerfile

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Update the VARIANT arg in docker-compose.yml to pick an Elixir version: 1.9, 1.10, 1.10.4
2-
ARG VARIANT=latest
2+
ARG VARIANT="1.12.3"
33
FROM elixir:${VARIANT}
44

55
# This Dockerfile adds a non-root user with sudo access. Update the “remoteUser” property in
@@ -15,17 +15,18 @@ ARG COMMON_SCRIPT_SOURCE="https://raw.githubusercontent.com/microsoft/vscode-dev
1515
ARG COMMON_SCRIPT_SHA="dev-mode"
1616

1717
# Optional Settings for Phoenix
18-
ARG PHOENIX_VERSION="1.5.4"
18+
ARG PHOENIX_VERSION="1.6.2"
1919

20+
# [Optional] Setup nodejs
2021
ARG NODE_SCRIPT_SOURCE="https://raw.githubusercontent.com/microsoft/vscode-dev-containers/main/script-library/node-debian.sh"
2122
ARG NODE_SCRIPT_SHA="dev-mode"
2223
ARG NODE_VERSION="none"
2324
ENV NVM_DIR=/usr/local/share/nvm
2425
ENV NVM_SYMLINK_CURRENT=true
2526
ENV PATH=${NVM_DIR}/current/bin:${PATH}
2627

27-
# [Choice] Node.js version: none, lts/*, 16, 14, 12, 10
28-
ARG NODE_VERSION="lts/*"
28+
# [Optional, Choice] Node.js version: none, lts/*, 16, 14, 12, 10
29+
ARG NODE_VERSION="none"
2930

3031
# Install needed packages and setup non-root user. Use a separate RUN statement to add your own dependencies.
3132
RUN apt-get update \

containers/elixir-phoenix-postgres/.devcontainer/docker-compose.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@ services:
77
dockerfile: Dockerfile
88
args:
99
# Elixir Version: 1.9, 1.10, 1.10.4, ...
10-
VARIANT: "1.11.2"
10+
VARIANT: "1.12.3"
1111
# Phoenix Version: 1.4.17, 1.5.4, ...
12-
PHOENIX_VERSION: "1.5.7"
12+
PHOENIX_VERSION: "1.6.2"
1313
# Node Version: 10, 11, ...
14-
NODE_VERSION: "10"
14+
NODE_VERSION: "none"
1515

1616
volumes:
1717
- ..:/workspace:cached

0 commit comments

Comments
 (0)