Skip to content
This repository was archived by the owner on Nov 30, 2023. It is now read-only.

Commit bf66dd4

Browse files
committed
Bug fixes
1 parent ddadb45 commit bf66dd4

File tree

7 files changed

+28
-25
lines changed

7 files changed

+28
-25
lines changed

containers/docker-in-docker-compose/README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@ You can adapt your own existing development container Docker Compose setup to su
2525
1. First, install the Docker CLI in your dev container. From `.devcontainer/Dockerfile`:
2626

2727
```Dockerfile
28-
RUN apt-get install -y apt-transport-https ca-certificates curl gnupg-agent software-properties-common lsb-release \
28+
RUN apt-get update \
29+
#
30+
# Install Docker CE CLI
31+
&& apt-get install -y apt-transport-https ca-certificates curl gnupg-agent software-properties-common lsb-release \
2932
&& curl -fsSL https://download.docker.com/linux/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/gpg | apt-key add - 2>/dev/null \
3033
&& add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/$(lsb_release -is | tr '[:upper:]' '[:lower:]') $(lsb_release -cs) stable" \
3134
&& apt-get update \

containers/docker-in-docker/README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,10 @@ You can adapt your own existing development container Dockerfile to support this
2525
1. First, install the Docker CLI in your container. From `.devcontainer/Dockerfile`:
2626

2727
```Dockerfile
28-
# Install Docker CE CLI
29-
RUN apt-get install -y apt-transport-https ca-certificates curl gnupg-agent software-properties-common lsb-release \
28+
RUN apt-get update \
29+
#
30+
# Install Docker CE CLI
31+
&& apt-get install -y apt-transport-https ca-certificates curl gnupg-agent software-properties-common lsb-release \
3032
&& curl -fsSL https://download.docker.com/linux/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/gpg | apt-key add - 2>/dev/null \
3133
&& add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/$(lsb_release -is | tr '[:upper:]' '[:lower:]') $(lsb_release -cs) stable" \
3234
&& apt-get update \

containers/kubernetes-helm/.devcontainer/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ RUN apt-get update \
2626
&& apt-get install -y docker-ce-cli \
2727
#
2828
# Install kubectl
29-
&& curl -sSLO -o /usr/local/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl \
29+
&& curl -sSL -o /usr/local/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl \
3030
&& chmod +x /usr/local/bin/kubectl \
3131
#
3232
# Install Helm

containers/kubernetes-helm/README.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -76,21 +76,21 @@ You can adapt your own existing development container Dockerfile to support this
7676
4. Finally, update your Dockerfile to install all of the needed CLIs in the container. From `.devcontainer/Dockerfile`:
7777

7878
```Dockerfile
79-
# Install Docker CE CLI
80-
RUN apt-get install -y apt-transport-https ca-certificates curl gnupg-agent software-properties-common lsb-release \
79+
RUN apt-get update \
80+
#
81+
# Install Docker CE CLI
82+
&& apt-get install -y apt-transport-https ca-certificates curl gnupg-agent software-properties-common lsb-release \
8183
&& curl -fsSL https://download.docker.com/linux/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/gpg | apt-key add - 2>/dev/null \
8284
&& add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/$(lsb_release -is | tr '[:upper:]' '[:lower:]') $(lsb_release -cs) stable" \
8385
&& apt-get update \
84-
&& apt-get install -y docker-ce-cli
85-
86-
# Install kubectl
87-
RUN curl -s https://packages.cloud.google.com/apt/doc/apt-key.gpg | apt-key add - 2>/dev/null \
88-
&& echo "deb https://apt.kubernetes.io/ kubernetes-$(lsb_release -cs) main" | tee -a /etc/apt/sources.list.d/kubernetes.list \
89-
&& apt-get update \
90-
&& apt-get install -y kubectl
91-
92-
# Install Helm
93-
RUN curl -s https://raw.githubusercontent.com/helm/helm/master/scripts/get | bash -
86+
&& apt-get install -y docker-ce-cli \
87+
#
88+
# Install kubectl
89+
&& curl -sSL -o /usr/local/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl \
90+
&& chmod +x /usr/local/bin/kubectl \
91+
#
92+
# Install Helm
93+
curl -s https://raw.githubusercontent.com/helm/helm/master/scripts/get | bash -
9494
```
9595

9696
5. Press <kbd>F1</kbd> and run **Remote-Containers: Rebuild Container** so the changes take effect.

containers/ruby-2-rails-5/.devcontainer/Dockerfile

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,12 @@ RUN apt-get update \
1010
&& apt-get -y install --no-install-recommends apt-utils 2>&1 \
1111
#
1212
# Install vim, git, process tools, lsb-release
13-
RUN apt-get update \
14-
&& apt-get install -y \
15-
vim \
16-
git \
17-
procps \
18-
lsb-release \
19-
#
13+
&& apt-get install -y \
14+
vim \
15+
git \
16+
procps \
17+
lsb-release \
18+
#
2019
# Install ruby
2120
&& apt-get install -y \
2221
ruby \

containers/ruby-2-rails-5/.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@
1212
// "postCreateCommand": "cd ${input:projectName} && bundle install",
1313

1414
"extensions": [
15-
"rebornix.Ruby",
15+
"rebornix.Ruby"
1616
]
1717
}

containers/ruby-2-sinatra/.devcontainer/Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ RUN apt-get update \
1010
&& apt-get -y install --no-install-recommends apt-utils 2>&1 \
1111
#
1212
# Install vim, git, process tools, lsb-release
13-
&& apt-get update \
1413
&& apt-get install -y \
1514
vim \
1615
git \

0 commit comments

Comments
 (0)