Fix Node script SHA256 sum check (#1174)

neilvcarvalho · web-flow · commit d8cdfa2651be · 2021-11-24T17:42:53.000-08:00
The checksum verification is comparing the node-debian.sh to the common-debian.sh checksum, which fails if the `COMMON_SCRIPT_SHA` environment variable is set. This fixes the issue, comparing the node-debian.sh checksum to the `NODE_SCRIPT_SHA` environment variable.
diff --git a/containers/elixir-phoenix-postgres/.devcontainer/Dockerfile b/containers/elixir-phoenix-postgres/.devcontainer/Dockerfile
@@ -39,7 +39,7 @@ RUN apt-get update \
   # [Optional] Install Node.js for use with web applications
   && if [ "$NODE_VERSION" != "none" ]; then \
   curl -sSL ${NODE_SCRIPT_SOURCE} -o /tmp/node-setup.sh \
-  && ([ "${NODE_SCRIPT_SHA}" = "dev-mode" ] || (echo "${COMMON_SCRIPT_SHA} */tmp/node-setup.sh" | sha256sum -c -)) \
+  && ([ "${NODE_SCRIPT_SHA}" = "dev-mode" ] || (echo "${NODE_SCRIPT_SHA} */tmp/node-setup.sh" | sha256sum -c -)) \
   && /bin/bash /tmp/node-setup.sh "${NVM_DIR}" "${NODE_VERSION}" "${USERNAME}"; \
   fi \
   #

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ RUN apt-get update \`
`39`	`39`	`# [Optional] Install Node.js for use with web applications`
`40`	`40`	`&& if [ "$NODE_VERSION" != "none" ]; then \`
`41`	`41`	`curl -sSL ${NODE_SCRIPT_SOURCE} -o /tmp/node-setup.sh \`
`42`		`- && ([ "${NODE_SCRIPT_SHA}" = "dev-mode" ] \|\| (echo "${COMMON_SCRIPT_SHA} */tmp/node-setup.sh" \| sha256sum -c -)) \`
	`42`	`+ && ([ "${NODE_SCRIPT_SHA}" = "dev-mode" ] \|\| (echo "${NODE_SCRIPT_SHA} */tmp/node-setup.sh" \| sha256sum -c -)) \`
`43`	`43`	`&& /bin/bash /tmp/node-setup.sh "${NVM_DIR}" "${NODE_VERSION}" "${USERNAME}"; \`
`44`	`44`	`fi \`
`45`	`45`	`#`