Skip to content
This repository was archived by the owner on Nov 30, 2023. It is now read-only.

Commit d9ffe74

Browse files
authored
Resolve #1111 (#1112)
1 parent a512e88 commit d9ffe74

File tree

16 files changed

+27
-618
lines changed

16 files changed

+27
-618
lines changed

containers/dotnet-fsharp/.devcontainer/Dockerfile

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,6 @@ FROM mcr.microsoft.com/vscode/devcontainers/dotnet:0-5.0
44
ARG NODE_VERSION="lts/*"
55
RUN if [ "${NODE_VERSION}" != "none" ]; then su vscode -c "umask 0002 && . /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"; fi
66

7-
# [Option] Install Azure CLI
8-
ARG INSTALL_AZURE_CLI="false"
9-
COPY library-scripts/azcli-debian.sh /tmp/library-scripts/
10-
RUN if [ "$INSTALL_AZURE_CLI" = "true" ]; then bash /tmp/library-scripts/azcli-debian.sh; fi \
11-
&& apt-get clean -y && rm -rf /var/lib/apt/lists/* /tmp/library-scripts
12-
137
# [Optional] Uncomment this section to install additional OS packages.
148
# RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
159
# && apt-get -y install --no-install-recommends <your-package-list-here>

containers/dotnet-fsharp/.devcontainer/devcontainer.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@
55
"dockerfile": "Dockerfile",
66
"args": {
77
// Options
8-
"NODE_VERSION": "lts/*",
9-
"INSTALL_AZURE_CLI": "false",
10-
"UPGRADE_PACKAGES": "false"
8+
"NODE_VERSION": "lts/*"
119
}
1210
},
1311

containers/dotnet-fsharp/.devcontainer/library-scripts/README.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

containers/dotnet-fsharp/.devcontainer/library-scripts/azcli-debian.sh

Lines changed: 0 additions & 186 deletions
This file was deleted.

containers/dotnet-fsharp/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -118,13 +118,13 @@ Given JavaScript front-end web client code written for use in conjunction with a
118118
}
119119
```
120120

121-
If you would like to install the Azure CLI update you can set the `INSTALL_AZURE_CLI` argument line in `.devcontainer/devcontainer.json`:
121+
If you would like to install the Azure CLI, you can reference [a dev container feature](https://aka.ms/vscode-remote/containers/dev-container-features) by adding the following to `.devcontainer/devcontainer.json`:
122122

123123
```json
124-
"args": {
125-
"VARIANT": "3.1",
126-
"NODE_VERSION": "14",
127-
"INSTALL_AZURE_CLI": "true"
124+
{
125+
"features": {
126+
"azure-cli": "latest"
127+
}
128128
}
129129
```
130130

containers/dotnet-mssql/.devcontainer/Dockerfile

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,6 @@ FROM mcr.microsoft.com/vscode/devcontainers/dotnet:${VARIANT}
66
ARG NODE_VERSION="none"
77
RUN if [ "${NODE_VERSION}" != "none" ]; then su vscode -c "umask 0002 && . /usr/local/share/nvm/nvm.sh && nvm install ${NODE_VERSION} 2>&1"; fi
88

9-
# [Option] Install Azure CLI
10-
ARG INSTALL_AZURE_CLI="false"
11-
COPY library-scripts/azcli-debian.sh /tmp/library-scripts/
12-
RUN if [ "$INSTALL_AZURE_CLI" = "true" ]; then bash /tmp/library-scripts/azcli-debian.sh; fi \
13-
&& apt-get clean -y && rm -rf /var/lib/apt/lists/* /tmp/library-scripts
14-
159
# Install SQL Tools: SQLPackage and sqlcmd
1610
COPY mssql/installSQLtools.sh installSQLtools.sh
1711
RUN bash ./installSQLtools.sh \

containers/dotnet-mssql/.devcontainer/docker-compose.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,11 @@ services:
66
context: .
77
dockerfile: Dockerfile
88
args:
9-
# [Choice] Update 'VARIANT' to pick a .NET Core version: 3.1, 5.0, 6.0, 6.0-bullseye, 6.0-buster
9+
# Update 'VARIANT' to pick a version of .NET: 3.1, 5.0, 6.0
10+
# Append -bullseye or -focal to pin to an OS version.
1011
VARIANT: 5.0-bullseye
11-
# [Choice] Node.js version: none, lts/*, 16, 14, 12, 10
12+
# Optional version of Node.js
1213
NODE_VERSION: "lts/*"
13-
# [Option] Install Azure CLI
14-
INSTALL_AZURE_CLI: "false"
1514

1615
volumes:
1716
- ..:/workspace:cached

containers/dotnet-mssql/.devcontainer/library-scripts/README.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)