Use NVM to install Node in .NET Core repos so new versions can be installed.

Author: Chuxel

containers/dotnetcore-2.1/.devcontainer/Dockerfile

@@ -2,8 +2,8 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License. See https://go.microsoft.com/fwlink/?linkid=2090316 for license information.
 #-------------------------------------------------------------------------------------------------------------
-
-FROM mcr.microsoft.com/dotnet/core/sdk:2.1
+ARG DOTNETCORE_VESRION=2.1
+FROM mcr.microsoft.com/dotnet/core/sdk:${DOTNETCORE_VESRION}
 
 # This Dockerfile adds a non-root 'vscode' user with sudo access. However, for Linux,
 # this user's GID/UID must match your local user UID/GID to avoid permission issues
@@ -15,7 +15,8 @@ ARG USER_GID=$USER_UID
 
 # [Optional] Version of Node.js to install.
 ARG INSTALL_NODE="true"
-ARG NODE_MAJOR_VERSION="10"
+ARG NODE_VERSION="lts/*"
+ENV NVM_DIR=/home/vscode/.nvm
 
 # [Optional] Install the Azure CLI
 ARG INSTALL_AZURE_CLI="false"
@@ -30,10 +31,34 @@ RUN apt-get update \
     # Verify git, process tools, lsb-release (common in install instructions for CLIs) installed
     && apt-get -y install git iproute2 procps lsb-release \
     #
+    # Create a non-root user to use if preferred - see https://aka.ms/vscode-remote/containers/non-root-user.
+    && groupadd --gid $USER_GID $USERNAME \
+    && useradd -s /bin/bash --uid $USER_UID --gid $USER_GID -m $USERNAME \
+    # [Optional] Add sudo support for the non-root user
+    && apt-get install -y sudo \
+    && echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME\
+    && chmod 0440 /etc/sudoers.d/$USERNAME \
+    #
     # [Optional] Install Node.js for ASP.NET Core Web Applicationss
     && if [ "$INSTALL_NODE" = "true" ]; then \
-        curl -sL https://deb.nodesource.com/setup_$NODE_MAJOR_VERSION.x | bash - \
-        && apt-get install -y nodejs; \
+        #
+        # Install nvm and Node
+        mkdir ${NVM_DIR} \
+        && curl -so- https://raw.githubusercontent.com/creationix/nvm/v0.34.0/install.sh | bash 2>&1 \
+        && chown -R vscode:vscode ${NVM_DIR} \
+        && /bin/bash -c "source $NVM_DIR/nvm.sh \
+            && nvm install ${NODE_VERSION} \
+            && nvm alias default ${NODE_VERSION}" 2>&1 \
+        && INIT_STRING='[ -s "$NVM_DIR/nvm.sh" ] && \\. "$NVM_DIR/nvm.sh"  && [ -s "$NVM_DIR/bash_completion" ] && \\. "$NVM_DIR/bash_completion"' \
+        && echo $INIT_STRING >> /home/vscode/.bashrc \
+        && echo $INIT_STRING >> /home/vscode/.zshrc \
+        && echo $INIT_STRING >> /root/.zshrc \
+        #
+        # Install yarn
+        && curl -sS https://dl.yarnpkg.com/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/pubkey.gpg | apt-key add - 2>/dev/null \
+        && echo "deb https://dl.yarnpkg.com/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/ stable main" | tee /etc/apt/sources.list.d/yarn.list \
+        && apt-get update \
+        && apt-get -y install --no-install-recommends yarn; \
     fi \
     #
     # [Optional] Install the Azure CLI
@@ -45,14 +70,6 @@ RUN apt-get update \
         && apt-get install -y azure-cli; \
     fi \
     #
-    # Create a non-root user to use if preferred - see https://aka.ms/vscode-remote/containers/non-root-user.
-    && groupadd --gid $USER_GID $USERNAME \
-    && useradd -s /bin/bash --uid $USER_UID --gid $USER_GID -m $USERNAME \
-    # [Optional] Add sudo support for the non-root user
-    && apt-get install -y sudo \
-    && echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME\
-    && chmod 0440 /etc/sudoers.d/$USERNAME \
-    #
     # Clean up
     && apt-get autoremove -y \
     && apt-get clean -y \

containers/dotnetcore-2.1/README.md

@@ -73,7 +73,7 @@ Given how frequently ASP.NET applications use Node.js for front end code, this c
 
 ```Dockerfile
 ARG INSTALL_NODE="true"
-ARG NODE_MAJOR_VERSION="10"
+ARG NODE_VERSION="10"
 ```
 
 If you would like to install the Azure CLI update this line in `.devcontainer/Dockerfile`:

containers/dotnetcore-2.2/.devcontainer/Dockerfile

@@ -3,9 +3,10 @@
 # Licensed under the MIT License. See https://go.microsoft.com/fwlink/?linkid=2090316 for license information.
 #-------------------------------------------------------------------------------------------------------------
 
-FROM mcr.microsoft.com/dotnet/core/sdk:2.2
+ARG DOTNETCORE_VESRION=2.2
+FROM mcr.microsoft.com/dotnet/core/sdk:${DOTNETCORE_VESRION}
 
-## This Dockerfile adds a non-root 'vscode' user with sudo access. However, for Linux,
+# This Dockerfile adds a non-root 'vscode' user with sudo access. However, for Linux,
 # this user's GID/UID must match your local user UID/GID to avoid permission issues
 # with bind mounts. Update USER_UID / USER_GID if yours is not 1000. See
 # https://aka.ms/vscode-remote/containers/non-root-user for details.
@@ -15,7 +16,8 @@ ARG USER_GID=$USER_UID
 
 # [Optional] Version of Node.js to install.
 ARG INSTALL_NODE="true"
-ARG NODE_MAJOR_VERSION="10"
+ARG NODE_VERSION="lts/*"
+ENV NVM_DIR=/home/vscode/.nvm
 
 # [Optional] Install the Azure CLI
 ARG INSTALL_AZURE_CLI="false"
@@ -30,10 +32,34 @@ RUN apt-get update \
     # Verify git, process tools, lsb-release (common in install instructions for CLIs) installed
     && apt-get -y install git iproute2 procps lsb-release \
     #
+    # Create a non-root user to use if preferred - see https://aka.ms/vscode-remote/containers/non-root-user.
+    && groupadd --gid $USER_GID $USERNAME \
+    && useradd -s /bin/bash --uid $USER_UID --gid $USER_GID -m $USERNAME \
+    # [Optional] Add sudo support for the non-root user
+    && apt-get install -y sudo \
+    && echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME\
+    && chmod 0440 /etc/sudoers.d/$USERNAME \
+    #
     # [Optional] Install Node.js for ASP.NET Core Web Applicationss
     && if [ "$INSTALL_NODE" = "true" ]; then \
-        curl -sL https://deb.nodesource.com/setup_$NODE_MAJOR_VERSION.x | bash - \
-        && apt-get install -y nodejs; \
+        #
+        # Install nvm and Node
+        mkdir ${NVM_DIR} \
+        && curl -so- https://raw.githubusercontent.com/creationix/nvm/v0.34.0/install.sh | bash 2>&1 \
+        && chown -R vscode:vscode ${NVM_DIR} \
+        && /bin/bash -c "source $NVM_DIR/nvm.sh \
+            && nvm install ${NODE_VERSION} \
+            && nvm alias default ${NODE_VERSION}" 2>&1 \
+        && INIT_STRING='[ -s "$NVM_DIR/nvm.sh" ] && \\. "$NVM_DIR/nvm.sh"  && [ -s "$NVM_DIR/bash_completion" ] && \\. "$NVM_DIR/bash_completion"' \
+        && echo $INIT_STRING >> /home/vscode/.bashrc \
+        && echo $INIT_STRING >> /home/vscode/.zshrc \
+        && echo $INIT_STRING >> /root/.zshrc \
+        #
+        # Install yarn
+        && curl -sS https://dl.yarnpkg.com/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/pubkey.gpg | apt-key add - 2>/dev/null \
+        && echo "deb https://dl.yarnpkg.com/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/ stable main" | tee /etc/apt/sources.list.d/yarn.list \
+        && apt-get update \
+        && apt-get -y install --no-install-recommends yarn; \
     fi \
     #
     # [Optional] Install the Azure CLI
@@ -45,14 +71,6 @@ RUN apt-get update \
         && apt-get install -y azure-cli; \
     fi \
     #
-    # Create a non-root user to use if preferred - see https://aka.ms/vscode-remote/containers/non-root-user.
-    && groupadd --gid $USER_GID $USERNAME \
-    && useradd -s /bin/bash --uid $USER_UID --gid $USER_GID -m $USERNAME \
-    # [Optional] Add sudo support for the non-root user
-    && apt-get install -y sudo \
-    && echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME\
-    && chmod 0440 /etc/sudoers.d/$USERNAME \
-    #
     # Clean up
     && apt-get autoremove -y \
     && apt-get clean -y \

containers/dotnetcore-2.2/README.md

@@ -73,7 +73,7 @@ Given how frequently ASP.NET applications use Node.js for front end code, this c
 
 ```Dockerfile
 ARG INSTALL_NODE="true"
-ARG NODE_MAJOR_VERSION="10"
+ARG NODE_VERSION="10"
 ```
 
 If you would like to install the Azure CLI update this line in `.devcontainer/Dockerfile`:

containers/dotnetcore-3.0/.devcontainer/Dockerfile

@@ -3,7 +3,8 @@
 # Licensed under the MIT License. See https://go.microsoft.com/fwlink/?linkid=2090316 for license information.
 #-------------------------------------------------------------------------------------------------------------
 
-FROM mcr.microsoft.com/dotnet/core/sdk:3.0
+ARG DOTNETCORE_VESRION=3.0
+FROM mcr.microsoft.com/dotnet/core/sdk:${DOTNETCORE_VESRION}
 
 # This Dockerfile adds a non-root 'vscode' user with sudo access. However, for Linux,
 # this user's GID/UID must match your local user UID/GID to avoid permission issues
@@ -15,7 +16,8 @@ ARG USER_GID=$USER_UID
 
 # [Optional] Version of Node.js to install.
 ARG INSTALL_NODE="true"
-ARG NODE_MAJOR_VERSION="10"
+ARG NODE_VERSION="lts/*"
+ENV NVM_DIR=/home/vscode/.nvm
 
 # [Optional] Install the Azure CLI
 ARG INSTALL_AZURE_CLI="false"
@@ -30,10 +32,34 @@ RUN apt-get update \
     # Verify git, process tools, lsb-release (common in install instructions for CLIs) installed
     && apt-get -y install git iproute2 procps lsb-release \
     #
+    # Create a non-root user to use if preferred - see https://aka.ms/vscode-remote/containers/non-root-user.
+    && groupadd --gid $USER_GID $USERNAME \
+    && useradd -s /bin/bash --uid $USER_UID --gid $USER_GID -m $USERNAME \
+    # [Optional] Add sudo support for the non-root user
+    && apt-get install -y sudo \
+    && echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME\
+    && chmod 0440 /etc/sudoers.d/$USERNAME \
+    #
     # [Optional] Install Node.js for ASP.NET Core Web Applicationss
     && if [ "$INSTALL_NODE" = "true" ]; then \
-        curl -sL https://deb.nodesource.com/setup_$NODE_MAJOR_VERSION.x | bash - \
-        && apt-get install -y nodejs; \
+        #
+        # Install nvm and Node
+        mkdir ${NVM_DIR} \
+        && curl -so- https://raw.githubusercontent.com/creationix/nvm/v0.34.0/install.sh | bash 2>&1 \
+        && chown -R vscode:vscode ${NVM_DIR} \
+        && /bin/bash -c "source $NVM_DIR/nvm.sh \
+            && nvm install ${NODE_VERSION} \
+            && nvm alias default ${NODE_VERSION}" 2>&1 \
+        && INIT_STRING='[ -s "$NVM_DIR/nvm.sh" ] && \\. "$NVM_DIR/nvm.sh"  && [ -s "$NVM_DIR/bash_completion" ] && \\. "$NVM_DIR/bash_completion"' \
+        && echo $INIT_STRING >> /home/vscode/.bashrc \
+        && echo $INIT_STRING >> /home/vscode/.zshrc \
+        && echo $INIT_STRING >> /root/.zshrc \
+        #
+        # Install yarn
+        && curl -sS https://dl.yarnpkg.com/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/pubkey.gpg | apt-key add - 2>/dev/null \
+        && echo "deb https://dl.yarnpkg.com/$(lsb_release -is | tr '[:upper:]' '[:lower:]')/ stable main" | tee /etc/apt/sources.list.d/yarn.list \
+        && apt-get update \
+        && apt-get -y install --no-install-recommends yarn; \
     fi \
     #
     # [Optional] Install the Azure CLI
@@ -45,14 +71,6 @@ RUN apt-get update \
         && apt-get install -y azure-cli; \
     fi \
     #
-    # Create a non-root user to use if preferred - see https://aka.ms/vscode-remote/containers/non-root-user.
-    && groupadd --gid $USER_GID $USERNAME \
-    && useradd -s /bin/bash --uid $USER_UID --gid $USER_GID -m $USERNAME \
-    # [Optional] Add sudo support for the non-root user
-    && apt-get install -y sudo \
-    && echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME\
-    && chmod 0440 /etc/sudoers.d/$USERNAME \
-    #
     # Clean up
     && apt-get autoremove -y \
     && apt-get clean -y \

containers/dotnetcore-3.0/README.md

@@ -1,8 +1,8 @@
-# C# (latest .NET Core)
+# C# (.NET Core 3.0)
 
 ## Summary
 
-*Develop C# and .NET Core (latest) based applications. Includes all needed SDKs, extensions, and dependencies.*
+*Develop C# and .NET Core 3.0 based applications. Includes all needed SDKs, extensions, and dependencies.*
 
 | Metadata | Value |  
 |----------|-------|
@@ -73,7 +73,7 @@ Given how frequently ASP.NET applications use Node.js for front end code, this c
 
 ```Dockerfile
 ARG INSTALL_NODE="true"
-ARG NODE_MAJOR_VERSION="10"
+ARG NODE_VERSION="10"
 ```
 
 If you would like to install the Azure CLI update this line in `.devcontainer/Dockerfile`: