Add null checks for issue retrieval in various components (#336)

Author: bhavyaus

api/api.ts

@@ -31,7 +31,7 @@ export interface GitHub {
 }
 
 export interface GitHubIssue extends GitHub {
-	getIssue(): Promise<Issue>;
+	getIssue(): Promise<Issue | undefined>;
 
 	postComment(body: string): Promise<void>;
 	deleteComment(id: number): Promise<void>;

api/octokit.js

@@ -326,21 +326,30 @@ export class OctoKitIssue extends OctoKit implements GitHubIssue {
 			await this.octokit.rest.issues.unlock({ ...this.params, issue_number: this.issueData.number });
 	}
 
-	async getIssue(): Promise<Issue> {
+	async getIssue(): Promise<Issue | undefined> {
 		if (isIssue(this.issueData)) {
 			safeLog('Got issue data from query result ' + this.issueData.number);
 			return this.issueData;
 		}
 
 		safeLog('Fetching issue ' + this.issueData.number);
-		const issue = (
-			await this.octokit.rest.issues.get({
-				...this.params,
-				issue_number: this.issueData.number,
-				mediaType: { previews: ['squirrel-girl'] },
-			})
-		).data;
-		return (this.issueData = this.octokitIssueToIssue(issue));
+		try {
+			const issue = (
+				await this.octokit.rest.issues.get({
+					...this.params,
+					issue_number: this.issueData.number,
+					mediaType: { previews: ['squirrel-girl'] },
+				})
+			).data;
+			return (this.issueData = this.octokitIssueToIssue(issue));
+		} catch (err) {
+			const statusError = err as RequestError;
+			if (statusError.status === 404) {
+				safeLog('Issue not found');
+				return;
+			}
+			throw err;
+		}
 	}
 
 	async postComment(body: string): Promise<void> {
@@ -380,7 +389,7 @@ export class OctoKitIssue extends OctoKit implements GitHubIssue {
 			...this.params,
 			issue_number: this.issueData.number,
 			per_page: 100,
-			...(last ? { per_page: 1, page: (await this.getIssue()).numComments } : {}),
+			...(last ? { per_page: 1, page: (await this.getIssue())?.numComments } : {}),
 		});
 
 		for await (const page of response) {
@@ -465,7 +474,7 @@ export class OctoKitIssue extends OctoKit implements GitHubIssue {
 		}
 		alreadyChecked.push(this.issueData.number);
 
-		if ((await this.getIssue()).open) {
+		if ((await this.getIssue())?.open) {
 			return;
 		}
 
@@ -534,7 +543,7 @@ export class OctoKitIssue extends OctoKit implements GitHubIssue {
 				}).getClosingInfo(alreadyChecked);
 
 				if (closed) {
-					if (Math.abs(closed.timestamp - ((await this.getIssue()).closedAt ?? 0)) < 5000) {
+					if (Math.abs(closed.timestamp - ((await this.getIssue())?.closedAt ?? 0)) < 5000) {
 						closingCommit = closed;
 						break;
 					}

api/octokit.ts

@@ -33,6 +33,7 @@ export class AuthorVerifiedLabeler {
 
 	async run(): Promise<void> {
 		const issue = await this.github.getIssue();
+		if (!issue) return;
 
 		if (
 			!issue.open &&

author-verified/AuthorVerified.js

@@ -60,6 +60,7 @@ class ApplyLabels extends Action {
 			};
 
 			const issueData = await issue.getIssue();
+			if (!issueData) continue;
 
 			if (issueData.labels.includes('invalid')) {
 				safeLog(`issue ${labeling.number} is invalid, skipping`);

author-verified/AuthorVerified.ts

@@ -36,6 +36,7 @@ class FetchIssues extends Action {
 		for await (const page of github.query({ q: query })) {
 			for (const issue of page) {
 				const issueData = await issue.getIssue();
+				if (!issueData) continue;
 
 				// Probably spam. Tagged for later review
 				if (issueData.author.name === 'ghost') {
@@ -65,6 +66,8 @@ class FetchIssues extends Action {
 								const linkedIssueData = await github
 									.getIssueByNumber(+linkedIssue)
 									.getIssue();
+								if (!linkedIssueData) continue;
+
 								const normalized = normalizeIssue(linkedIssueData);
 								additionalInfo = `\n\n${normalized.title}\n\n${normalized.body}`;
 								const linkedIssueAssignee = linkedIssueData.assignees[0];