Improve error handling and retry logic for authentication token retrieval; refactor end game check in CodeReviewChat (#334)

Author: bhavyaus

code-review-chat/CodeReviewChat.js

@@ -81,7 +81,7 @@ export function createPRObject(pullRequestFromApi: any): PR {
 }
 
 class Chatter {
-	constructor(protected slackToken: string, protected notificationChannelID: string) { }
+	constructor(protected slackToken: string, protected notificationChannelID: string) {}
 
 	async getChat(): Promise<{ client: WebClient; channel: string }> {
 		const web = new WebClient(this.slackToken);
@@ -282,7 +282,13 @@ export class CodeReviewChat extends Chatter {
 			return;
 		}
 
-		const isEndGame = (await isInsiderFrozen()) ?? false;
+		let isEndGame = false;
+		try {
+			isEndGame = (await isInsiderFrozen()) ?? false;
+		} catch (error) {
+			safeLog(`Error determining if insider is frozen: ${(error as Error).message}`);
+		}
+
 		// This is an external PR which already received one review and is just awaiting a second
 		const data = await this.issue.getIssue();
 		if (this._externalContributorPR) {

code-review-chat/CodeReviewChat.ts

@@ -253,9 +253,29 @@ export async function getAuthenticationToken(): Promise<string> {
 	const installationId = getInput('app_installation_id');
 	const privateKey = getInput('app_private_key');
 	if (appId && installationId && privateKey) {
-		const appAuth = createAppAuth({ appId, installationId, privateKey });
-		return (await appAuth({ type: 'installation' })).token;
-	} else {
-		throw Error('Input required: app_id, app_installation_id, app_private_key');
+		const maxAttempts = 3;
+		let attempts = 0;
+
+		while (attempts < maxAttempts) {
+			try {
+				const appAuth = createAppAuth({ appId, installationId, privateKey });
+				return (await appAuth({ type: 'installation' })).token;
+			} catch (error: any) {
+				if (error.response && error.response.status === 504) {
+					attempts++;
+					const delay = Math.pow(2, attempts) * 1000; // Exponential backoff
+					safeLog(
+						`Attempt ${attempts} failed with 504 error. Retrying in ${delay / 1000} seconds.`,
+					);
+					if (attempts >= maxAttempts) {
+						throw new Error('Max retry attempts reached. Please try again later');
+					}
+					await new Promise((resolve) => setTimeout(resolve, delay));
+				} else {
+					throw error;
+				}
+			}
+		}
 	}
+	throw Error('Failed to get authentication token');
 }