Skip to content
This repository was archived by the owner on Nov 14, 2025. It is now read-only.

Commit bf30ae8

Browse files
authored
Add support for external PR review timestamp filtering in getTeamMemberReviews (#323)
1 parent d81cacb commit bf30ae8

File tree

4 files changed

+16
-2
lines changed

4 files changed

+16
-2
lines changed

code-review-chat/CodeReviewChat.js

Lines changed: 6 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

code-review-chat/CodeReviewChat.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -360,6 +360,7 @@ export async function getTeamMemberReviews(
360360
repo: string,
361361
owner: string,
362362
ghIssue: GitHubIssue | OctoKitIssue,
363+
isExternalPR?: boolean,
363364
) {
364365
const reviews = await octokit.pulls.listReviews({
365366
pull_number: prNumber,
@@ -401,6 +402,13 @@ export async function getTeamMemberReviews(
401402
if (reviewTimestamp < lastCommitUnixTimestamp) {
402403
continue;
403404
}
405+
406+
// Check that the team member review occurred in the last 24 hours for external PRs
407+
const twentyFourHoursAgo = Date.now() - 24 * 60 * 60 * 1000;
408+
if (isExternalPR && reviewTimestamp < twentyFourHoursAgo) {
409+
continue;
410+
}
411+
404412
const existingReview = latestReviews.get(review.user.login);
405413
if (!existingReview || reviewTimestamp > new Date(existingReview.submitted_at).getTime()) {
406414
latestReviews.set(review.user.login, review);

code-review-chat/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

code-review-chat/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ class CodeReviewChatAction extends Action {
135135
payload.repository.name,
136136
payload.repository.owner.login,
137137
issue,
138+
true /* isExternalPR */,
138139
);
139140
safeLog(`Found ${teamMemberReviews?.length ?? 0} reviews from team members`);
140141
// Get only the approving reviews from team members

0 commit comments

Comments
 (0)