Add support for assigning cc'ed users to issues based on available triagers (#338)

Author: bhavyaus

classifier-deep/apply/apply-labels/index.js

@@ -47,6 +47,9 @@ class ApplyLabels extends Action {
 			readFileSync(join(__dirname, '../issue_labels.json'), { encoding: 'utf8' }),
 		);
 
+		const vscodeToolsAPI = new VSCodeToolsAPIManager();
+		const triagers = await vscodeToolsAPI.getTriagerGitHubIds();
+
 		for (const labeling of labelings) {
 			const issue = new OctoKitIssue(token, { owner, repo }, { number: labeling.number });
 
@@ -81,6 +84,22 @@ class ApplyLabels extends Action {
 				continue;
 			}
 
+			// Check if the issue has any cc'ed users and assign them if they are available
+			const issueBody = issueData.body;
+			const ccMatches = (issueBody.match(/@(\w+)/g) || []).map((match) => match.replace('@', ''));
+			let performedAssignment = false;
+			for (const ccMatch of ccMatches) {
+				if (triagers.includes(ccMatch)) {
+					safeLog("assigning cc'ed user", ccMatch);
+					performedAssignment = true;
+					await issue.addAssignee(ccMatch);
+				}
+			}
+
+			if (performedAssignment) {
+				continue;
+			}
+
 			safeLog(
 				'not skipping',
 				JSON.stringify({
@@ -144,7 +163,6 @@ class ApplyLabels extends Action {
 				}
 			}
 
-			let performedAssignment = false;
 			if (potentialAssignees.length && !debug) {
 				for (const assignee of potentialAssignees) {
 					const hasBeenAssigned = await issue.getAssigner(assignee).catch(() => undefined);
@@ -159,29 +177,8 @@ class ApplyLabels extends Action {
 			if (!performedAssignment) {
 				safeLog('could not find assignee, picking a random one...');
 				try {
-					const vscodeToolsAPI = new VSCodeToolsAPIManager();
-					const triagers = await vscodeToolsAPI.getTriagerGitHubIds();
-					safeLog('Acquired list of available triagers');
 					const available = triagers;
 					if (available) {
-						// Check if the issue has any cc'ed users and assign them if they are available
-						const issueBody = issueData.body;
-						const ccMatches = (issueBody.match(/@(\w+)/g) || []).map((match) =>
-							match.replace('@', ''),
-						);
-
-						for (const ccMatch of ccMatches) {
-							if (available.includes(ccMatch)) {
-								safeLog("assigning cc'ed user", ccMatch);
-								await issue.addAssignee(ccMatch);
-								performedAssignment = true;
-							}
-						}
-
-						if (performedAssignment) {
-							continue;
-						}
-
 						// Shuffle the array
 						for (let i = available.length - 1; i > 0; i--) {
 							const j = Math.floor(Math.random() * (i + 1));