Update README & node version

Author: badsyntax

.nvmrc

@@ -1 +1 @@
-lts/dubnium
+lts/erbium

README.md

@@ -4,68 +4,60 @@
 
 <!-- ![Build status](https://github.com/badsyntax/vscode-gradle/workflows/Node%20CI/badge.svg) -->
 
-This extension provides support to run gradle tasks.
+Run gradle tasks in VS Code.
 
 ![Main image](images/task-list.png)
 
-## Usage
-
-Run any of the following commands:
-
-- `Gradle: Run task`
-- `Gradle: Refresh tasks`
-- `Gradle: Kill all tasks`
+## Features
 
-Or run gradle tasks from the explorer.
+- List gradle tasks in the Command Palette
+- List gradle tasks in the Explorer
+- Read project or all tasks (via custom gradle tasks arguments)
+- Run gradle tasks (via Command Palette or Explorer) and view output
+- Load tasks when `build.gradle` file is found in root workspace
+- Refresh tasks when `build.gradle` changes
+- Kill gradle task processes
 
-## Settings
+## Setup
 
-Use global `gradlew`:
+The extension requires a local gradle wrapper executable at the root of the workspace.
 
-```json
-"gradle.useCommand": "gradlew"
-```
+You can configure this with the `gradle.useCommand` setting:
 
-Use local `gradlew` (default):
+### Linux/MacOS (default):
 
 ```json
-"gradle.useCommand": "./gradlew"
+{
+  "gradle.useCommand": "./gradlew"
+}
 ```
 
-Use project tasks:
+### Windows:
 
 ```json
-"gradle.tasks.args": ""
+{
+  "gradle.useCommand": ".\\gradlew.bat"
+}
 ```
 
-Use all tasks (default):
+## Usage
 
-```json
-"gradle.tasks.args": "--all"
-```
+Run any of the following commands:
 
-Disable tasks explorer:
+- `Gradle: Run task`
+- `Gradle: Refresh tasks`
+- `Gradle: Kill all tasks`
 
-```json
-"gradle.enableTasksExplorer": false
-```
+Or run gradle tasks from the explorer.
 
-Enable tasks explorer (default):
+## Settings
 
 ```json
-"gradle.enableTasksExplorer": true
+"gradle.useCommand": "./gradlew",  // path to local gradle wrapper
+"gradle.tasks.args": "--all",      // gradle tasks args
+"gradle.enableTasksExplorer": true // show gradle tasks in the explorer
 ```
 
-## Features
-
-- List gradle tasks in the Command Palette
-- List gradle tasks in the Explorer
-- Read project or all tasks (via custom gradle tasks arguments)
-- Run gradle tasks (via Command Palette or Explorer) and view output
-- Load tasks when `build.gradle` file is found in root workspace
-- Refresh tasks when `build.gradle` changes
-- Kill gradle task processes
-
 ## Troubleshooting
 
 <details><summary>The extension hangs with "Refreshing gradle tasks"...</summary>
@@ -74,13 +66,9 @@ Eventually the command should fail with an error message. This is usually due to
 
 </details>
 
-<details><summary>The extension show an error "Unable to refresh gradle tasks: Command failed: Error: spawn gradlew..."</summary>
-
-This means the global `gradlew` command is not available. Change the command setting to point to a local `gradlew` command:
+<details><summary>The extension show an error "Unable to refresh gradle tasks: Command failed..."</summary>
 
-```json
-"gradle.useCommand": "./gradlew"
-```
+The path to the gradle wrapper does not exist. Change the `"gradle.useCommand"` setting to point to a local `gradlew` executable.
 
 </details>
 

TODO.md

@@ -7,3 +7,4 @@
 - [ ] Only refresh on activation if activation is not refresh
 - [x] Run gradle task before check if there are available tasks
 - [ ] Check standards on global gradlew
+- [ ] Add task args

foo.js

@@ -0,0 +1,3 @@
+{
+    "gradle.useCommand": ".\\gradlew.bat"
+}

package-lock.json

@@ -36,7 +36,7 @@ function runTask(
   const cmd = getCommand();
   const args = [task.label];
   const options = { cwd: workspace.rootPath };
-  const feedback = `Running ${cmd}`;
+  const feedback = `Running ${cmd} ${task.label}`;
   const statusbar: Disposable = window.setStatusBarMessage(feedback);
 
   outputChannel.show();

src/Gradle.ts

@@ -14,7 +14,6 @@ export default class Process {
     readonly processLogger?: ProcessLogger
   ) {
     this.deferred = new Deferred();
-
     this.childProcess = spawn(command, args, options);
 
     let stdoutData = '';

src/Process.ts

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<classpath>
+	<classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-12/"/>
+	<classpathentry kind="con" path="org.eclipse.buildship.core.gradleclasspathcontainer"/>
+	<classpathentry kind="output" path="bin/default"/>
+</classpath>

test-fixtures/gradle-windows/.classpath

@@ -0,0 +1,5 @@
+# Ignore Gradle project-specific cache directory
+.gradle
+
+# Ignore Gradle build output directory
+build

test-fixtures/gradle-windows/.gitignore

@@ -0,0 +1,23 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<projectDescription>
+	<name>gradle</name>
+	<comment>Project gradle created by Buildship.</comment>
+	<projects>
+	</projects>
+	<buildSpec>
+		<buildCommand>
+			<name>org.eclipse.jdt.core.javabuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+		<buildCommand>
+			<name>org.eclipse.buildship.core.gradleprojectbuilder</name>
+			<arguments>
+			</arguments>
+		</buildCommand>
+	</buildSpec>
+	<natures>
+		<nature>org.eclipse.jdt.core.javanature</nature>
+		<nature>org.eclipse.buildship.core.gradleprojectnature</nature>
+	</natures>
+</projectDescription>