Merge pull request #39 from badsyntax/improve-error-logging

Improve error logging & change test style to bdd

Author: badsyntax

.github/workflows/nodejs.yml

@@ -33,7 +33,7 @@ jobs:
           npm test
 
   build-test-macos:
-    runs-on: macOS-latest
+    runs-on: macos-latest
 
     strategy:
       matrix:
@@ -51,12 +51,13 @@ jobs:
           architecture: x64
       - name: Build & test extension
         run: |
+          unset npm_config_prefix
           npm ci
           npm run lint
           npm test
 
   build-test-windows:
-    runs-on: windows-2019
+    runs-on: windows-latest
 
     strategy:
       matrix:

package-lock.json

@@ -179,9 +179,11 @@
     "@types/glob": "^7.1.1",
     "@types/mocha": "^5.2.7",
     "@types/node": "^12.12.7",
+    "@types/sinon": "^7.5.0",
     "glob": "^7.1.6",
     "mocha": "^6.2.2",
     "prettier": "^1.19.1",
+    "sinon": "^7.5.0",
     "typescript": "^3.7.2",
     "vscode": "^1.1.36",
     "vscode-test": "^1.2.3"

package.json

@@ -5,7 +5,8 @@ import {
   ExtensionContext,
   Disposable,
   TaskProvider,
-  StatusBarAlignment
+  StatusBarAlignment,
+  OutputChannel
 } from 'vscode';
 import { GradleTasksTreeDataProvider } from './gradleView';
 import {
@@ -19,7 +20,8 @@ import { getCustomBuildFile, getIsTasksExplorerEnabled } from './config';
 let treeDataProvider: GradleTasksTreeDataProvider | undefined;
 
 function registerTaskProvider(
-  context: ExtensionContext
+  context: ExtensionContext,
+  outputChannel: OutputChannel
 ): Disposable | undefined {
   function invalidateTaskCaches() {
     invalidateTasksCache();
@@ -57,8 +59,6 @@ function registerTaskProvider(
       1
     );
 
-    const outputChannel = window.createOutputChannel('Gradle Tasks');
-
     const provider: TaskProvider = new GradleTaskProvider(
       statusBarItem,
       outputChannel
@@ -68,7 +68,6 @@ function registerTaskProvider(
     context.subscriptions.push(watcher);
     context.subscriptions.push(workspaceWatcher);
     context.subscriptions.push(statusBarItem);
-    context.subscriptions.push(outputChannel);
     context.subscriptions.push(taskProvider);
     return taskProvider;
   }
@@ -111,12 +110,14 @@ interface ExtensionApi {}
 export async function activate(
   context: ExtensionContext
 ): Promise<ExtensionApi> {
-  registerTaskProvider(context);
+  const outputChannel = window.createOutputChannel('Gradle Tasks');
+  context.subscriptions.push(outputChannel);
+  registerTaskProvider(context, outputChannel);
   treeDataProvider = registerExplorer(context);
   if ((await hasGradleBuildFile()) && getIsTasksExplorerEnabled()) {
     commands.executeCommand('setContext', 'gradle:showTasksExplorer', true);
   }
-  return {};
+  return { outputChannel };
 }
 
 export function deactivate(): void {}