Fixes #888 (#889)

* Fixes #888

* PR fixes - changed to boolean

* Squashed commit of the following:

commit b76da40b8b3488f7e3840e20780e8757d1854586
Author: srfrnk <[email protected]>
Date:   Sat Oct 10 09:11:32 2020 +0100

    removed newline at EOF

commit c80801c90e73942ab69f5266f5a5e525a236bd39
Author: srfrnk <[email protected]>
Date:   Sat Oct 10 09:10:45 2020 +0100

    Revert "removed newline at EOF"

    This reverts commit 8e2f872.

commit bd90bf2
Author: srfrnk <[email protected]>
Date:   Sat Oct 10 09:10:07 2020 +0100

    added newline at EOF

commit 8e2f872
Author: srfrnk <[email protected]>
Date:   Sat Oct 10 09:04:51 2020 +0100

    removed newline at EOF

commit c997a6c
Author: Srfrnk <[email protected]>
Date:   Sat Oct 10 09:03:55 2020 +0100

    Removed newline at EOF

commit 7738ddf
Author: Srfrnk <[email protected]>
Date:   Sat Oct 10 09:03:00 2020 +0100

    Edit outside vscode to prevent adding newline at EOF

commit 586824f
Author: Srfrnk <[email protected]>
Date:   Sat Oct 10 09:01:58 2020 +0100

    edit outside vscode to prevent whitespace changes.

Author: srfrnk

Configuration.md

@@ -23,6 +23,7 @@
 * [Modify the settings.json (User Setting)](#modify-the-settingsjson-user-setting)
   * java.debug.settings.console
   * java.debug.settings.forceBuildBeforeLaunch
+  * java.debug.settings.onBuildFailureProceed 
   * java.debug.settings.hotCodeReplace
   * java.debug.settings.enableRunDebugCodeLens
 * [FAQ](#faq)
@@ -329,6 +330,8 @@ In some cases, you may want to start your program with the external builder and
 
 - `java.debug.settings.forceBuildBeforeLaunch` - Force building the workspace before launching java program, defaults to `true`. Sometimes you may be bothered with the message *"Build failed, do you want to continue?"*, you could disable this setting to suppress the message.
 
+- `java.debug.settings.onBuildFailureProceed` - Sometimes you may be bothered with the message *"Build failed, do you want to continue?"*, you could use this setting to suppress the message and proceed.
+
 - `java.debug.settings.hotCodeReplace` - Reload the changed Java classes during debugging, defaults to `manual`. It supports `manual`, `auto`, `never`.
   - `manual` - Click the toolbar to apply the changes.  
   ![hcr](https://user-images.githubusercontent.com/14052197/67256313-f5697600-f4b8-11e9-9db6-54540b6350ad.png)

README.md

@@ -108,6 +108,7 @@ Please also check the documentation of [Language Support for Java by Red Hat](ht
   - never - Never apply the changes.
 - `java.debug.settings.enableRunDebugCodeLens`: enable the code lens provider for the run and debug buttons over main entry points, defaults to `true`.
 - `java.debug.settings.forceBuildBeforeLaunch`: force building the workspace before launching java program, defaults to `true`.
+- `java.debug.settings.onBuildFailureProceed`: Force to proceed when build fails, defaults to false.
 - `java.debug.settings.console`: The specified console to launch Java program, defaults to `integratedTerminal`. If you want to customize the console for a specific debug session, please modify the 'console' config in launch.json.
   - `internalConsole` - VS Code debug console (input stream not supported).
   - `integratedTerminal` - VS Code integrated terminal.

package.json

@@ -636,6 +636,11 @@
           "description": "%java.debugger.configuration.forceBuildBeforeLaunch%",
           "default": true
         },
+        "java.debug.settings.onBuildFailureProceed": {
+          "type": "boolean",
+          "description": "%java.debugger.configuration.onBuildFailureProceed%",
+          "default": false
+        },
         "java.debug.settings.console": {
           "type": "string",
           "enum": [

package.nls.json

@@ -53,6 +53,7 @@
     "java.debugger.configuration.hotCodeReplace.description": "Reload the changed Java classes during debugging. Make sure 'java.autobuild.enabled' is not disabled.",
     "java.debugger.configuration.enableRunDebugCodeLens.description": "Enable the run and debug code lens providers over main methods.",
     "java.debugger.configuration.forceBuildBeforeLaunch": "Force building the workspace before launching java program.",
+    "java.debugger.configuration.onBuildFailureProceed": "Force to proceed when build fails",
     "java.debugger.configuration.console": "The specified console to launch Java program. If you want to customize the console for a specific debug session, please modify the 'console' config in launch.json.",
     "java.debugger.configuration.exceptionBreakpoint.skipClasses": "Skip the specified classes when breaking on exception. You could use the built-in variables such as '$JDK' and '$Libraries' to skip a group of classes, or add a specific class name expression, e.g. java.*, *.Foo",
     "java.debugger.configuration.jdwp.limitOfVariablesPerJdwpRequest.description": "The maximum number of variables or fields that can be requested in one JDWP request. The higher the value, the less frequently debuggee will be requested when expanding the variable view. Also a large number can cause JDWP request timeout.",

src/build.ts

@@ -9,6 +9,9 @@ import * as commands from "./commands";
 import * as lsPlugin from "./languageServerPlugin";
 import * as utility from "./utility";
 
+const JAVA_DEBUG_CONFIGURATION = "java.debug.settings";
+const ON_BUILD_FAILURE_PROCEED = "onBuildFailureProceed";
+
 export async function buildWorkspace(): Promise<boolean> {
     const buildResult = await instrumentOperation("build", async (operationId: string) => {
         let error;
@@ -32,6 +35,9 @@ export async function buildWorkspace(): Promise<boolean> {
 }
 
 async function handleBuildFailure(operationId: string, err: any): Promise<boolean> {
+    const configuration = vscode.workspace.getConfiguration(JAVA_DEBUG_CONFIGURATION);
+    const onBuildFailureProceed = configuration.get<boolean>(ON_BUILD_FAILURE_PROCEED);
+
     if (err instanceof utility.JavaExtensionNotEnabledError) {
         utility.guideToInstallJavaExtension();
         return false;
@@ -47,8 +53,8 @@ async function handleBuildFailure(operationId: string, err: any): Promise<boolea
             vscode.commands.executeCommand("workbench.actions.view.problems");
         }
 
-        const ans = await vscode.window.showErrorMessage("Build failed, do you want to continue?",
-            "Proceed", "Fix...", "Cancel");
+        const ans = onBuildFailureProceed ? "Proceed" : (await vscode.window.showErrorMessage("Build failed, do you want to continue?",
+            "Proceed", "Fix...", "Cancel"));
         sendInfo(operationId, {
             operationName: "build",
             choiceForBuildError: ans || "esc",