Skip to content

Commit 4ce7a94

Browse files
Update telemetry wrapper (#810)
Signed-off-by: Jinbo Wang <[email protected]>
1 parent 74c3a13 commit 4ce7a94

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@
347347
"anyOf": [
348348
{
349349
"enum": [
350-
"${command:PickJavaProcess}"
350+
"${command:PickJavaProcess}"
351351
],
352352
"description": "%java.debugger.attach.processPicker.description%",
353353
"default": "${command:pickJavaProcess}"
@@ -620,7 +620,7 @@
620620
},
621621
"dependencies": {
622622
"lodash": "^4.17.15",
623-
"vscode-extension-telemetry": "^0.1.5",
624-
"vscode-extension-telemetry-wrapper": "^0.7.2"
623+
"vscode-extension-telemetry": "^0.1.6",
624+
"vscode-extension-telemetry-wrapper": "^0.8.0"
625625
}
626626
}

src/logger.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ export enum Type {
1212
ACTIVATEEXTENSION = "activateExtension", // TODO: Activation belongs to usage data, remove this category.
1313
}
1414

15+
const SENSITIVE_PROPS = ["message", "stacktrace", "detailmessage"];
16+
1517
class Logger implements vscode.Disposable {
1618
private reporter: TelemetryReporter = null;
1719

@@ -39,7 +41,7 @@ class Logger implements vscode.Disposable {
3941
}
4042

4143
if (type === Type.EXCEPTION || type === Type.USAGEERROR) {
42-
this.reporter.sendTelemetryErrorEvent(type, properties, measures);
44+
this.reporter.sendTelemetryErrorEvent(type, properties, measures, SENSITIVE_PROPS);
4345
} else {
4446
this.reporter.sendTelemetryEvent(type, properties, measures);
4547
}

0 commit comments

Comments
 (0)