Skip to content

Commit 7439648

Browse files
drop error event for some environment (#805)
* drop error event for some environment Signed-off-by: Jinbo Wang <[email protected]> * Pass firstParty to constructor directly Signed-off-by: Jinbo Wang <[email protected]>
1 parent 656beaa commit 7439648

File tree

4 files changed

+114
-32
lines changed

4 files changed

+114
-32
lines changed

package-lock.json

Lines changed: 101 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,7 @@
599599
},
600600
"dependencies": {
601601
"lodash": "^4.17.15",
602-
"vscode-extension-telemetry": "0.1.1",
603-
"vscode-extension-telemetry-wrapper": "0.4.0"
602+
"vscode-extension-telemetry": "^0.1.4",
603+
"vscode-extension-telemetry-wrapper": "^0.7.1"
604604
}
605605
}

src/extension.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,14 @@ import { initializeThreadOperations } from "./threadOperations";
1717
import * as utility from "./utility";
1818

1919
export async function activate(context: vscode.ExtensionContext) {
20-
await initializeFromJsonFile(context.asAbsolutePath("./package.json"));
20+
await initializeFromJsonFile(context.asAbsolutePath("./package.json"), {
21+
firstParty: true,
22+
});
2123
await instrumentOperation("activation", initializeExtension)(context);
2224
}
2325

2426
function initializeExtension(operationId: string, context: vscode.ExtensionContext) {
25-
logger.initialize(context);
27+
logger.initialize(context, true);
2628
logger.log(Type.ACTIVATEEXTENSION, {}); // TODO: Activation belongs to usage data, remove this line.
2729
logger.log(Type.USAGEDATA, {
2830
description: "activateExtension",

src/logger.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export enum Type {
1515
class Logger implements vscode.Disposable {
1616
private reporter: TelemetryReporter = null;
1717

18-
public initialize(context: vscode.ExtensionContext): void {
18+
public initialize(context: vscode.ExtensionContext, firstParty?: boolean): void {
1919
if (this.reporter) {
2020
return;
2121
}
@@ -28,7 +28,7 @@ class Logger implements vscode.Disposable {
2828
aiKey: extensionPackage.aiKey,
2929
};
3030
if (packageInfo.aiKey) {
31-
this.reporter = new TelemetryReporter(packageInfo.name, packageInfo.version, packageInfo.aiKey);
31+
this.reporter = new TelemetryReporter(packageInfo.name, packageInfo.version, packageInfo.aiKey, firstParty);
3232
}
3333
}
3434
}
@@ -38,7 +38,11 @@ class Logger implements vscode.Disposable {
3838
return;
3939
}
4040

41-
this.reporter.sendTelemetryEvent(type, properties, measures);
41+
if (type === Type.EXCEPTION || type === Type.USAGEERROR) {
42+
this.reporter.sendTelemetryErrorEvent(type, properties, measures);
43+
} else {
44+
this.reporter.sendTelemetryEvent(type, properties, measures);
45+
}
4246
}
4347

4448
public logMessage(type: Type, message: string): void {

0 commit comments

Comments
 (0)