Support environment variable for port number in launch.json debug configuration (#984)

testforstephen · web-flow · commit bed2489f62b1 · 2021-04-22T09:41:54.000+08:00
diff --git a/package.json b/package.json
@@ -403,7 +403,7 @@
                 "description": "%java.debugger.attach.hostName.description%"
               },
               "port": {
-                "type": "number",
+                "type": ["number", "string"],
                 "description": "%java.debugger.attach.port.description%"
               },
               "processId": {
diff --git a/src/configurationProvider.ts b/src/configurationProvider.ts
@@ -313,7 +313,8 @@ export class JavaDebugConfigurationProvider implements vscode.DebugConfiguration
                     }
                 }
             } else if (config.request === "attach") {
-                if (config.hostName && config.port) {
+                if (config.hostName && config.port && Number.isInteger(Number(config.port))) {
+                    config.port = Number(config.port);
                     config.processId = undefined;
                     // Continue if the hostName and port are configured.
                 } else if (config.processId !== undefined) {

Original file line number	Diff line number	Diff line change
`@@ -313,7 +313,8 @@ export class JavaDebugConfigurationProvider implements vscode.DebugConfiguration`
`313`	`313`	`}`
`314`	`314`	`}`
`315`	`315`	`} else if (config.request === "attach") {`
`316`		`- if (config.hostName && config.port) {`
	`316`	`+ if (config.hostName && config.port && Number.isInteger(Number(config.port))) {`
	`317`	`+ config.port = Number(config.port);`
`317`	`318`	`config.processId = undefined;`
`318`	`319`	`// Continue if the hostName and port are configured.`
`319`	`320`	`} else if (config.processId !== undefined) {`