Address design comments. (#42)

Author: yaohaizh

jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/PackageCommand.java

@@ -113,6 +113,11 @@ private static List<PackageNode> getContainers(PackageParams query, IProgressMon
 					try {
 						entry = JavaCore.getResolvedClasspathEntry(entry);
 						IClasspathContainer container = JavaCore.getClasspathContainer(entry.getPath(), javaProject);
+						// HACK: There is an initialization issue for the first container.
+						if (container == null) {
+							container = JavaCore.getClasspathContainer(entry.getPath(), javaProject);
+						}
+
 						if (container != null) {
 							return new ContainerNode(container.getDescription(), container.getPath().toPortableString(), NodeKind.CONTAINER,
 									entry.getEntryKind());

package.json

@@ -35,11 +35,7 @@
       {
         "command": "java.project.create",
         "title": "Create Java Project",
-        "category": "Java",
-        "icon": {
-          "dark": "images/dark/icon-create.svg",
-          "light": "images/light/icon-create.svg"
-        }
+        "category": "Java"
       },
       {
         "command": "java.view.package.refresh",
@@ -51,25 +47,31 @@
         }
       }
     ],
+    "configuration": {
+      "type": "object",
+      "title": "Java Dependency Configuration",
+      "properties": {
+        "java.dependency.showOutline": {
+          "type": "boolean",
+          "description": "Enable show outline in the Java Dependency explorer",
+          "default": false
+        }
+      }
+    },
     "menus": {
       "view/title": [
-        {
-          "command": "java.project.create",
-          "when": "view == javaProjectExplorer",
-          "group": "navigation@0"
-        },
         {
           "command": "java.view.package.refresh",
           "when": "view == javaProjectExplorer",
-          "group": "navigation@1"
+          "group": "navigation@0"
         }
       ]
     },
     "views": {
       "explorer": [
         {
           "id": "javaProjectExplorer",
-          "name": "Java Packages"
+          "name": "Java Dependency"
         }
       ]
     }
@@ -103,4 +105,4 @@
     "vscode-extension-telemetry": "0.0.17",
     "xml2js": "^0.4.19"
   }
-}
+}

src/settings.ts

@@ -0,0 +1,12 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license.
+
+import { workspace, WorkspaceConfiguration } from "vscode";
+
+export class Settings {
+    public static showOutline(): boolean {
+        return this._debugSettingsRoot.get("showOutline");
+    }
+
+    private static _debugSettingsRoot: WorkspaceConfiguration = workspace.getConfiguration("java.dependency");
+}

src/views/typeRootNode.ts

@@ -6,6 +6,7 @@ import { Commands } from "../commands";
 import { INodeData } from "../java/nodeData";
 import { ITypeRootNodeData, TypeRootKind } from "../java/typeRootNodeData";
 import { Services } from "../services";
+import { Settings } from "../settings";
 import { DataNode } from "./dataNode";
 import { ExplorerNode } from "./explorerNode";
 import { SymbolNode } from "./symbolNode";
@@ -44,6 +45,9 @@ export class TypeRootNode extends DataNode {
             return Services.context.asAbsolutePath("./images/file-type-java.svg");
         }
     }
+    protected hasChildren(): boolean {
+        return Settings.showOutline();
+    }
 
     private getSymbols(document: TextDocument): Thenable<SymbolInformation[]> {
         return commands.executeCommand<SymbolInformation[]>(