Skip to content

Commit 3554bcd

Browse files
authored
chore: remove ASKUSER option(#686)
1 parent a27b2ae commit 3554bcd

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

src/tasks/buildArtifact/GenerateJarExecutor.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,11 @@ import { globby } from "globby";
66
import * as _ from "lodash";
77
import { basename, dirname, extname, isAbsolute, join, normalize, relative } from "path";
88
import { Disposable, ProgressLocation, QuickInputButtons, QuickPickItem, Uri, window, WorkspaceFolder } from "vscode";
9-
import { sendInfo } from "vscode-extension-telemetry-wrapper";
109
import { Jdtls } from "../../java/jdtls";
1110
import { INodeData } from "../../java/nodeData";
1211
import { IExportJarStepExecutor } from "./IExportJarStepExecutor";
1312
import { IClasspath, IStepMetadata } from "./IStepMetadata";
14-
import { createPickBox, ExportJarMessages, ExportJarStep, ExportJarTargets, getExtensionApi, toPosixPath } from "./utility";
13+
import { createPickBox, ExportJarMessages, ExportJarStep, getExtensionApi, toPosixPath } from "./utility";
1514

1615
export class GenerateJarExecutor implements IExportJarStepExecutor {
1716

@@ -34,10 +33,7 @@ export class GenerateJarExecutor implements IExportJarStepExecutor {
3433
throw new Error(ExportJarMessages.fieldUndefinedMessage(ExportJarMessages.Field.WORKSPACEFOLDER, this.currentStep));
3534
}
3635
let destPath = "";
37-
if (stepMetadata.outputPath === ExportJarTargets.SETTING_ASKUSER || stepMetadata.outputPath === "") {
38-
if (stepMetadata.outputPath === ExportJarTargets.SETTING_ASKUSER) {
39-
sendInfo("", { exportJarPath: stepMetadata.outputPath });
40-
}
36+
if (stepMetadata.outputPath === "") {
4137
const outputUri: Uri | undefined = await window.showSaveDialog({
4238
defaultUri: Uri.file(join(folder.uri.fsPath, `${folder.name}.jar`)),
4339
filters: {

src/tasks/buildArtifact/utility.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,6 @@ export const stepMap: Map<ExportJarStep, IExportJarStepExecutor> = new Map<Expor
2727
[ExportJarStep.GenerateJar, new GenerateJarExecutor()],
2828
]);
2929

30-
export namespace ExportJarTargets {
31-
export const SETTING_ASKUSER: string = "askUser";
32-
// tslint:disable-next-line: no-invalid-template-strings
33-
export const DEFAULT_OUTPUT_PATH: string = "${workspaceFolder}/${workspaceFolderBasename}.jar";
34-
}
35-
3630
export namespace ExportJarConstants {
3731
export const DEPENDENCIES: string = "dependencies";
3832
export const TEST_DEPENDENCIES: string = "testDependencies";

0 commit comments

Comments
 (0)