fix: Add null check (#607)

Signed-off-by: sheche <[email protected]>

Author: jdneo

jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/ExtUtils.java

@@ -11,6 +11,7 @@
 
 package com.microsoft.jdtls.ext.core;
 
+import java.io.File;
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.util.Arrays;
@@ -29,6 +30,7 @@
 import org.eclipse.jdt.core.JavaModelException;
 import org.eclipse.jdt.internal.core.JarEntryDirectory;
 import org.eclipse.jdt.internal.core.JarEntryFile;
+import org.eclipse.jdt.launching.IVMInstall;
 import org.eclipse.jdt.launching.JavaRuntime;
 import org.eclipse.jdt.ls.core.internal.JavaLanguageServerPlugin;
 
@@ -112,7 +114,15 @@ public static URI getContainerURI(IJavaProject javaProject, IClasspathContainer
         switch (container.getKind()) {
             case IClasspathContainer.K_DEFAULT_SYSTEM: // JRE Container
             case IClasspathContainer.K_SYSTEM:
-                return JavaRuntime.getVMInstall(javaProject).getInstallLocation().toURI();
+                IVMInstall vmInstall = JavaRuntime.getVMInstall(javaProject);
+                if (vmInstall == null) {
+                    return null;
+                }
+                File installLocation = vmInstall.getInstallLocation();
+                if (installLocation == null) {
+                    return null;
+                }
+                return installLocation.toURI();
             case IClasspathContainer.K_APPLICATION: // Plugin Container, Maven Container, etc
                 return null; // TODO: find out a good way to detect these containers' uri
             default: // Persistent container (e.g. /src/main/java)

package-lock.json

@@ -617,30 +617,30 @@
   "devDependencies": {
     "@types/fs-extra": "^9.0.13",
     "@types/glob": "^7.2.0",
-    "@types/lodash": "^4.14.178",
+    "@types/lodash": "^4.14.181",
     "@types/minimatch": "^3.0.3",
     "@types/mocha": "^9.1.0",
-    "@types/node": "^14.14.0",
+    "@types/node": "^14.18.12",
     "@types/semver": "^7.3.9",
     "@types/vscode": "1.63.0",
     "copy-webpack-plugin": "^9.1.0",
     "glob": "^7.2.0",
     "mocha": "^9.2.2",
     "ts-loader": "^9.2.8",
     "tslint": "^6.1.3",
-    "typescript": "^4.6.2",
+    "typescript": "^4.6.3",
     "vscode-extension-tester": "^4.2.4",
     "vscode-test": "^1.6.1",
-    "webpack": "^5.70.0",
+    "webpack": "^5.72.0",
     "webpack-cli": "^4.9.2"
   },
   "dependencies": {
     "await-lock": "^2.1.0",
     "fs-extra": "^10.0.1",
     "globby": "^11.1.0",
     "lodash": "^4.17.21",
-    "minimatch": "^3.0.4",
-    "semver": "^7.3.5",
+    "minimatch": "^3.1.2",
+    "semver": "^7.3.6",
     "vscode-extension-telemetry-wrapper": "^0.12.0",
     "vscode-tas-client": "^0.1.31"
   }