fix: Better handling the import error hint (#747)

Author: jdneo

jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/ProjectCommand.java

@@ -296,25 +296,29 @@ public static String getModuleName(IJavaProject project) {
 
     public static boolean checkImportStatus() {
         IProject[] projects = ProjectUtils.getAllProjects();
+        boolean hasError = false;
         for (IProject project : projects) {
             if (ProjectsManager.DEFAULT_PROJECT_NAME.equals(project.getName())) {
                 continue;
             }
+
+            // if a Java project found, we think it as success import now.
+            if (ProjectUtils.isJavaProject(project)) {
+                return false;
+            }
+
             try {
-                List<IMarker> markers = ResourceUtils.getErrorMarkers(project);
-                if (markers != null) {
-                    boolean hasError = markers.stream().anyMatch(m -> {
-                        return m.getAttribute(IMarker.SEVERITY, 0) == IMarker.SEVERITY_ERROR;
-                    });
-                    if (hasError) {
-                        return true;
-                    }
+                int maxProblemSeverity = project.findMaxProblemSeverity(null, true, IResource.DEPTH_ONE);
+                if (maxProblemSeverity == IMarker.SEVERITY_ERROR) {
+                    hasError = true;
+                    break;
                 }
             } catch (CoreException e) {
                 JdtlsExtActivator.log(e);
             }
         }
-        return false;
+
+        return hasError;
     }
 
     private static void reportExportJarMessage(String terminalId, int severity, String message) {

src/views/dependencyDataProvider.ts

@@ -173,6 +173,12 @@ export class DependencyDataProvider implements TreeDataProvider<ExplorerNode> {
                 return this._rootItems;
             }
 
+            const hasJavaError: boolean = await Jdtls.checkImportStatus();
+            if (hasJavaError) {
+                contextManager.setContextValue(Context.IMPORT_FAILED, true);
+                return [];
+            }
+
             const rootItems: ExplorerNode[] = [];
             const folders = workspace.workspaceFolders;
             if (folders && folders.length) {
@@ -192,12 +198,7 @@ export class DependencyDataProvider implements TreeDataProvider<ExplorerNode> {
                 }
             }
             if (_.isEmpty(rootItems)) {
-                const hasJavaError: boolean = await Jdtls.checkImportStatus();
-                if (hasJavaError) {
-                    contextManager.setContextValue(Context.IMPORT_FAILED, true);
-                } else {
-                    contextManager.setContextValue(Context.NO_JAVA_PROJECT, true);
-                }
+                contextManager.setContextValue(Context.NO_JAVA_PROJECT, true);
             }
             return rootItems;
         } finally {