Skip to content

Commit de4a64b

Browse files
authored
UX: Polish messages for task type migration (#675)
1 parent 93d1ef7 commit de4a64b

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/tasks/migration/CodeActionProvider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { DiagnosticProvider } from "./DiagnosticProvider";
88

99
export class CodeActionProvider implements vscode.CodeActionProvider {
1010

11-
public static JAVA_UPDATE_DEPRECATED_TASK_TITLE = "Update deprecated task";
11+
public static JAVA_UPDATE_DEPRECATED_TASK_TITLE = `Change to \"${ExportJarTaskProvider.exportJarType}\"`;
1212
public static JAVA_BUILD_ARTIFACT_TYPE = `"type": "${ExportJarTaskProvider.exportJarType}"`;
1313

1414
public provideCodeActions(document: vscode.TextDocument, range: vscode.Range | vscode.Selection,

src/tasks/migration/DiagnosticProvider.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ import { DeprecatedExportJarTaskProvider, ExportJarTaskProvider } from "../../ex
1010

1111
export class DiagnosticProvider implements vscode.Disposable {
1212
public static DIAGNOSTIC_SOURCE = "Project Manager for Java";
13-
public static DEPRECATED_TASK_TYPE_DECLARATION = `\"type\": \"${DeprecatedExportJarTaskProvider.type}\"`;
14-
public static DEPRECATED_TASK_TYPE_MESSAGE = `Tasks with type \"${DeprecatedExportJarTaskProvider.type}\" are deprecated and will not be supported in the future, please use \"${ExportJarTaskProvider.exportJarType}\" instead.`;
13+
public static DEPRECATED_TASK_TYPE_MESSAGE = `The type \"${DeprecatedExportJarTaskProvider.type}\" is deprecated, please use \"${ExportJarTaskProvider.exportJarType}\" instead.`;
1514
private diagnosticCollection: vscode.DiagnosticCollection;
1615
private disposables: vscode.Disposable[] = [];
1716
private refreshDiagnosticsTrigger: any;

0 commit comments

Comments
 (0)