Skip to content

Commit 28dd72e

Browse files
authored
Info button follow fistView setting (#191)
Signed-off-by: Rome Li <[email protected]>
1 parent 7fd2c65 commit 28dd72e

File tree

2 files changed

+17
-9
lines changed

2 files changed

+17
-9
lines changed

src/extension.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,12 @@ import { dispose as disposeTelemetryWrapper, initialize, instrumentOperation } f
77
import { initialize as initUtils } from "./utils";
88
import { initialize as initCommands } from "./commands";
99
import { initialize as initRecommendations } from "./recommendation";
10-
import { initialize as initMisc, showReleaseNotesOnStart } from "./misc";
10+
import { initialize as initMisc, showReleaseNotesOnStart, HelpViewType } from "./misc";
1111
import { showOverviewPageOnActivation } from "./overview";
1212
import { validateJavaRuntime } from "./java-runtime";
1313
// import { JavaGettingStartedViewSerializer } from "./getting-started";
1414
import { scheduleAction } from "./utils/scheduler";
1515

16-
enum ViewType {
17-
Auto = "auto",
18-
Overview = "overview",
19-
GettingStarted = "gettingStarted",
20-
}
21-
2216
export async function activate(context: vscode.ExtensionContext) {
2317
initializeTelemetry(context);
2418
await instrumentOperation("activation", initializeExtension)(context);
@@ -53,7 +47,7 @@ async function initializeExtension(operationId: string, context: vscode.Extensio
5347
async function presentFirstView(context: vscode.ExtensionContext) {
5448
const config = vscode.workspace.getConfiguration("java.help");
5549
const firstView = config.get("firstView");
56-
if (firstView === ViewType.GettingStarted) {
50+
if (firstView === HelpViewType.GettingStarted) {
5751
await showGettingStartedView(context);
5852
} else {
5953
await showOverviewPageOnActivation(context);

src/misc/index.ts

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,23 @@
44
import * as vscode from "vscode";
55
import { getReleaseNotesEntries, findLatestReleaseNotes, timeToString } from "../utils";
66

7+
export enum HelpViewType {
8+
Auto = "auto",
9+
Overview = "overview",
10+
GettingStarted = "gettingStarted",
11+
}
12+
713
function showInfoButton() {
14+
const config = vscode.workspace.getConfiguration("java.help");
15+
const firstView = config.get("firstView");
16+
817
let infoButton = vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Right);
9-
infoButton.command = "java.overview";
18+
if (firstView === HelpViewType.GettingStarted) {
19+
infoButton.command = "java.gettingStarted";
20+
} else {
21+
infoButton.command = "java.overview";
22+
}
23+
1024
infoButton.text = "$(info)";
1125
infoButton.tooltip = "Learn more about Java features";
1226
infoButton.show();

0 commit comments

Comments
 (0)