Skip to content

Commit 5873b04

Browse files
Redact JWT token (#1434)
1 parent d9a4296 commit 5873b04

File tree

5 files changed

+13
-7
lines changed

5 files changed

+13
-7
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Change Log
22

3+
## 0.29.2
4+
### Changed
5+
- Update redact rules.
6+
37
## 0.29.1
48
### Fixed
59
- Fix vulnerabilities in dependencies.

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"displayName": "Extension Pack for Java",
44
"description": "Popular extensions for Java development that provides Java IntelliSense, debugging, testing, Maven/Gradle support, project management and more",
55
"license": "MIT",
6-
"version": "0.29.1",
6+
"version": "0.29.2",
77
"publisher": "vscjava",
88
"preview": false,
99
"engines": {

src/daemon/index.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,8 @@ async function traceLSPPerformance(javaExt: vscode.Extension<any>) {
202202
});
203203
}
204204

205+
const SOURCE_REGEX = /\r?\n----------------------------------- SOURCE BEGIN -------------------------------------\r?\n[\s\S]*/;
206+
205207
function redactDataProperties(data: any): string {
206208
if (data?.triggerKind !== undefined) {
207209
return JSON.stringify(data);
@@ -214,8 +216,8 @@ async function traceJavaExtension(javaExt: vscode.Extension<any>) {
214216
const javaExtVersion = javaExt.packageJSON?.version;
215217
const isPreReleaseVersion = /^\d+\.\d+\.\d{10}/.test(javaExtVersion);
216218
const remappedKeys: any = {
217-
"message": "lsmessage",
218-
"exception": "lsexception"
219+
"message": "servermessage",
220+
"exception": "serverexception"
219221
};
220222
javaExt.exports?.trackEvent?.((event: any) => {
221223
const metrics: any = {
@@ -237,7 +239,7 @@ async function traceJavaExtension(javaExt: vscode.Extension<any>) {
237239
for (const key of Object.keys(remappedKeys)) {
238240
if (metrics[key] !== undefined) {
239241
const newKey = remappedKeys[key];
240-
metrics[newKey] = metrics[key];
242+
metrics[newKey] = metrics[key].replace(SOURCE_REGEX, "<REDACTED: SOURCE CODE>"); // remove the source code from the message
241243
delete metrics[key];
242244
}
243245
}

src/extension.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ function initializeTelemetry(_context: vscode.ExtensionContext) {
9999
initialize(packageInfo.id, packageInfo.version, packageInfo.aiKey, {
100100
replacementOptions: [
101101
{
102-
lookup: /\s*Bearer\s+[\w-]*\.?[\w-]*\.?[A-Za-z0-9-_]*/,
102+
lookup: /eyJ[A-Za-z0-9_-]+\.eyJ[A-Za-z0-9_-]+\.[A-Za-z0-9-_]*/,
103103
replacementString: "<REDACTED: JWT token>"
104104
}
105105
]

0 commit comments

Comments
 (0)