fix walkthrough exp (#709)

Signed-off-by: Yan Zhang <[email protected]>

Author: Eskibear

src/extension.ts

@@ -49,7 +49,7 @@ async function initializeExtension(_operationId: string, context: vscode.Extensi
   const config = vscode.workspace.getConfiguration("java.help");
 
   // for control group where walkthrough is not enabled, present first view for once.
-  const walkthroughEnabled = isWalkthroughEnabled();
+  const walkthroughEnabled = await isWalkthroughEnabled();
   if (walkthroughEnabled === false && !context.globalState.get(KEY_IS_WELCOME_PAGE_VIEWED)) {
     presentFirstView(context);
     context.globalState.update(KEY_IS_WELCOME_PAGE_VIEWED, true)

src/utils/walkthrough.ts

@@ -7,7 +7,7 @@ import { TreatmentVariables } from "../exp/TreatmentVariables";
 
 export function isWalkthroughEnabled() {
 
-    const fromExp = getExpService().getTreatmentVariable<boolean>(TreatmentVariables.VSCodeConfig, TreatmentVariables.JavaWalkthroughEnabled);
+    const fromExp = getExpService()?.getTreatmentVariableAsync<boolean>(TreatmentVariables.VSCodeConfig, TreatmentVariables.JavaWalkthroughEnabled, true /* checkCache */) ?? false;
     // 	can be overridden by local settings "experiments.override.gettingStarted.overrideCategory.vscjava.vscode-java-pack#javaWelcome.when": "true"
     const fromSettings = workspace.getConfiguration("experiments.override.gettingStarted.overrideCategory").get<string>("vscjava.vscode-java-pack#javaWelcome.when") === "true";