fix: If a remote profile failed to open, the user cannot open it again (#650)

Author: CsCherrYY

src/formatter-settings/RemoteProfileProvider.ts

@@ -6,15 +6,21 @@ import { downloadFile } from "./utils";
 
 export class RemoteProfileProvider implements vscode.TextDocumentContentProvider {
 
-    public static scheme = "formatter";
+    public static scheme = "java-formatter";
+    private contentStorage: Map<string, string> = new Map<string, string>();
+
+    public setContent(url: string, content: string): void {
+        this.contentStorage.set(url, content);
+    }
 
     async provideTextDocumentContent(uri: vscode.Uri): Promise<string> {
         const originalUri: vscode.Uri = uri.with({ scheme: "https" });
-        return await downloadFile(originalUri.toString());
+        return this.contentStorage.get(originalUri.toString()) || downloadFile(originalUri.toString());
     } 
 }
 
+export let remoteProfileProvider = new RemoteProfileProvider();
+
 export function initRemoteProfileProvider(context: vscode.ExtensionContext) {
-    const remoteProfileProvider = new RemoteProfileProvider();
     context.subscriptions.push(vscode.workspace.registerTextDocumentContentProvider(RemoteProfileProvider.scheme, remoteProfileProvider));
 }

src/formatter-settings/index.ts

@@ -10,7 +10,7 @@ import { XMLSerializer } from "xmldom";
 import { loadTextFromFile } from "../utils";
 import { Example, getSupportedVSCodeSettings, JavaConstants, SupportedSettings, VSCodeSettings } from "./FormatterConstants";
 import { FormatterConverter } from "./FormatterConverter";
-import { RemoteProfileProvider } from "./RemoteProfileProvider";
+import { remoteProfileProvider, RemoteProfileProvider } from "./RemoteProfileProvider";
 import { DOMElement, ExampleKind, ProfileContent } from "./types";
 import { addDefaultProfile, downloadFile, getProfilePath, getAbsoluteTargetPath, getVSCodeSetting, isRemote, openFormatterSettings, parseProfile } from "./utils";
 export class JavaFormatterSettingsEditorProvider implements vscode.CustomTextEditorProvider {
@@ -272,13 +272,17 @@ export class JavaFormatterSettingsEditorProvider implements vscode.CustomTextEdi
         }
     }
 
-    private async downloadAndUse(settingsUrl: string): Promise<void> {
+    private async downloadAndUse(settingsUrl: string): Promise<boolean> {
         const profilePath = await getAbsoluteTargetPath(this.context, path.basename(settingsUrl));
         const data = await downloadFile(settingsUrl);
+        if (!data) {
+            return false;
+        }
         await fse.outputFile(profilePath, data);
         const workspaceFolders = vscode.workspace.workspaceFolders;
         await vscode.workspace.getConfiguration("java").update("format.settings.url", (workspaceFolders?.length ? vscode.workspace.asRelativePath(profilePath) : profilePath), !(workspaceFolders?.length));
         this.showFormatterSettingsEditor();
+        return true;
     }
 
     private checkProfileSettings = instrumentOperation("formatter.checkProfileSetting", async (operationId: string) => {
@@ -299,6 +303,11 @@ export class JavaFormatterSettingsEditorProvider implements vscode.CustomTextEdi
             this.checkedProfileSettings = await vscode.window.showInformationMessage("The active formatter profile is remote, do you want to open it in read-only mode or download and use it locally?",
                 "Open in read-only mode", "Download and use it locally").then(async (result) => {
                     if (result === "Open in read-only mode") {
+                        const content = await downloadFile(this.settingsUrl!);
+                        if (!content) {
+                            return false;
+                        }
+                        remoteProfileProvider.setContent(this.settingsUrl!, content);
                         this.readOnly = true;
                         return true;
                     } else if (result === "Download and use it locally") {

src/formatter-settings/utils.ts

@@ -156,7 +156,17 @@ export function parseProfile(document: vscode.TextDocument): ProfileContent {
 }
 
 export async function downloadFile(settingsUrl: string): Promise<string> {
-    return (await axios.get(settingsUrl)).data;
+    try {
+        return (await axios.get(settingsUrl)).data;
+    } catch (e) {
+        const answer = await vscode.window.showErrorMessage(`Failed to get the profile content from uri: ${settingsUrl}. Do you want to retry?`, "Retry", "Open Settings");
+        if (answer === "Retry") {
+            return downloadFile(settingsUrl);
+        } else if (answer === "Open Settings") {
+            openFormatterSettings();
+        }
+        return "";
+    }
 }
 
 export function openFormatterSettings(): void {