Skip to content

Commit dc3212c

Browse files
authored
Change JDK Version Requirement to 11 (#471)
Signed-off-by: Rome Li <[email protected]>
1 parent 521f197 commit dc3212c

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

src/java-runtime/assets/jdk.acquisition.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export const JdkAcquisitionPanel = (props: JdkAcquisitionPanelProps) => {
1919
<div className="col">
2020
<h3 className="font-weight-light">Configure</h3>
2121
<p>
22-
Java Development Kit (JDK) 8 or later is required for developing Java applications. The path to the JDK is searched in the following order:
22+
Java Development Kit (JDK) 11 or later is required for developing Java applications. The path to the JDK is searched in the following order:
2323
</p>
2424
<div className="card">
2525
<div className="card-body">
@@ -44,4 +44,3 @@ export const JdkAcquisitionPanel = (props: JdkAcquisitionPanelProps) => {
4444
</div>
4545
);
4646
};
47-

src/java-runtime/assets/jdk.installation.tsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,6 @@ export class JdkInstallationPanel extends React.Component<JdkInstallationPanelPr
8989
<div className="form-row" onChange={(event) => this.handleChange(event)}>
9090
<div className="form-group col-sm-6">
9191
<label>JDK Version:</label>
92-
<div className="form-check">
93-
<input className="form-check-input" type="radio" name="jdkVersion" id="openjdk8Radio" value="openjdk8" />
94-
<label className="form-check-label" htmlFor="openjdk8Radio">
95-
OpenJDK 8
96-
</label>
97-
</div>
9892
<div className="form-check">
9993
<input className="form-check-input" type="radio" name="jdkVersion" id="openjdk11Radio" value="openjdk11" defaultChecked />
10094
<label className="form-check-label" htmlFor="openjdk11Radio">

src/java-runtime/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { loadTextFromFile, getExtensionContext } from "../utils";
1313
import { JavaRuntimeEntry, JavaRuntimeEntryTypes } from "./types";
1414
import * as _ from "lodash";
1515

16-
const MIN_JDK_VERSION: number = 8;
16+
const MIN_JDK_VERSION: number = 11;
1717

1818
let javaRuntimeView: vscode.WebviewPanel | undefined;
1919

@@ -194,7 +194,7 @@ export async function findJavaRuntimeEntries(): Promise<JavaRuntimeEntry[]> {
194194
const version = await getJavaVersion(entry.path);
195195
if (version < MIN_JDK_VERSION) {
196196
entry.isValid = false;
197-
entry.hint = `JDK 8+ is required while the path is pointing to version ${version}`;
197+
entry.hint = `JDK 11+ is required while the path is pointing to version ${version}`;
198198
return entry;
199199
}
200200

0 commit comments

Comments
 (0)