Skip to content

Commit ef4013f

Browse files
authored
refine install-jdk webview (#838)
* refine install-jdk webview Signed-off-by: Yan Zhang <[email protected]> * fix package-lock Signed-off-by: Yan Zhang <[email protected]>
1 parent f8608c9 commit ef4013f

File tree

3 files changed

+31
-21
lines changed

3 files changed

+31
-21
lines changed

package-lock.json

Lines changed: 11 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,12 @@
5353
"onWebviewPanel:java.extGuide",
5454
"onCommand:java.welcome",
5555
"onWebviewPanel:java.welcome",
56+
"onCommand:java.installJdk",
57+
"onWebviewPanel:java.installJdk",
5658
"onCommand:java.classpathConfiguration",
5759
"onWebviewPanel:java.classpathConfiguration",
58-
"onCommand:java.formatterSettings"
60+
"onCommand:java.formatterSettings",
61+
"onWalkthrough:javaWelcome"
5962
],
6063
"contributes": {
6164
"walkthroughs": [
@@ -327,7 +330,7 @@
327330
"@types/expand-tilde": "^2.0.0",
328331
"@types/fs-extra": "^9.0.1",
329332
"@types/lodash": "^4.14.161",
330-
"@types/minimatch": "^3.0.3",
333+
"@types/minimatch": "^3.0.5",
331334
"@types/node": "^16.11.6",
332335
"@types/path-exists": "^3.0.0",
333336
"@types/react": "^17.0.0",
@@ -362,7 +365,7 @@
362365
"VisualStudioExptTeam.vscodeintellicode"
363366
],
364367
"dependencies": {
365-
"@iconify-icons/codicon": "^1.1.8",
368+
"@iconify-icons/codicon": "^1.1.25",
366369
"@iconify/react": "^1.1.4",
367370
"@microsoft/fast-react-wrapper": "^0.1.8",
368371
"@reduxjs/toolkit": "^1.5.0",

src/install-jdk/assets/features/components/AdoptiumJDKPanel.tsx

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,20 @@ const AdoptiumJDKPanel = () => {
7979
Download
8080
</div>
8181
<div className='asset-info'>
82-
<span>
83-
{asset.release_name}
84-
</span>
85-
<span> | </span>
86-
<span>
87-
{bytes(asset.binary.package?.size || 0, { unitSeparator: " " })}
88-
</span>
82+
<div>
83+
<span>
84+
{asset.binary.os}-{asset.binary.architecture}
85+
</span>
86+
</div>
87+
<div>
88+
<span>
89+
{asset.release_name}
90+
</span>
91+
<span> | </span>
92+
<span>
93+
{bytes(asset.binary.package?.size || 0, { unitSeparator: " " })}
94+
</span>
95+
</div>
8996
</div>
9097
</div>
9198
</Button>

0 commit comments

Comments
 (0)