Skip to content

Commit 4666c1a

Browse files
committed
Fix IW tests
1 parent fb44466 commit 4666c1a

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

src/interactive-window/interactiveWindow.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ import { chainWithPendingUpdates } from '../kernels/execution/notebookUpdater';
7474
import { initializeInteractiveOrNotebookTelemetryBasedOnUserAction } from '../kernels/telemetry/helper';
7575
import { generateMarkdownFromCodeLines, parseForComments } from '../platform/common/utils';
7676
import { IServiceContainer } from '../platform/ioc/types';
77-
import { KernelConnector } from '../notebooks/controllers/kernelConnector';
7877

7978
/**
8079
* ViewModel for an interactive window from the Jupyter extension's point of view.
@@ -255,6 +254,13 @@ export class InteractiveWindow implements IInteractiveWindowLoadable {
255254
await this.currentKernelInfo.kernelStarted.promise;
256255
return this.currentKernelInfo.kernel!;
257256
}
257+
const vscController = this.controllerRegistration.registered.find(
258+
(item) => item.controller.id === controller.id
259+
);
260+
if (!vscController) {
261+
// This cannot happen, but we need to make typescript happy.
262+
throw new Error('VSCController not available');
263+
}
258264
const kernelStarted = createDeferred<void>();
259265
kernelStarted.promise.catch(noop);
260266
this.currentKernelInfo = { controller, metadata, kernelStarted };
@@ -287,13 +293,9 @@ export class InteractiveWindow implements IInteractiveWindowLoadable {
287293
};
288294
// When connecting, we need to update the sys info message
289295
this.updateSysInfoMessage(this.getSysInfoMessage(metadata, SysInfoReason.Start), false, sysInfoCell);
290-
const kernel = await KernelConnector.connectToNotebookKernel(
291-
metadata,
292-
this.serviceContainer,
293-
{ resource: this.owner, notebook: this.notebookDocument, controller },
296+
const kernel = await vscController.connectToKernel(
297+
{ resource: this.owner, notebook: this.notebookDocument },
294298
new DisplayOptions(false),
295-
this.internalDisposables,
296-
'jupyterExtension',
297299
onKernelStarted,
298300
onKernelStartCompleted
299301
);

0 commit comments

Comments
 (0)