Skip to content

Commit a520b86

Browse files
authored
Pin pythreejs to a working version (#11182)
1 parent f0c4d6f commit a520b86

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

TELEMETRY.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -952,9 +952,9 @@ No properties for event
952952
traceCellMessage(cell, `kernel.executeCell, ${getDisplayPath(cell.notebook.uri)}`);
953953
initializeInteractiveOrNotebookTelemetryBasedOnUserAction(this.resourceUri, this.kernelConnectionMetadata);
954954
sendKernelTelemetryEvent(this.resourceUri, Telemetry.ExecuteCell);
955+
this.sendKernelStartedTelemetry();
955956
const stopWatch = new StopWatch();
956957
const sessionPromise = this.startJupyterSession();
957-
const promise = this.kernelExecution.executeCell(sessionPromise, cell, codeOverride);
958958
```
959959

960960

@@ -2007,12 +2007,12 @@ No description provided
20072007

20082008
[src/kernels/kernel.ts](https://github.com/microsoft/vscode-jupyter/tree/main/src/kernels/kernel.ts)
20092009
```typescript
2010-
await this.executeSilently(session, startupCode, {
2011-
traceErrors: true,
2012-
traceErrorsMessage: 'Error executing jupyter extension internal startup code',
2013-
telemetryName: Telemetry.KernelStartupCodeFailure
2014-
});
2015-
2010+
await this.executeSilently(session, startupCode, {
2011+
traceErrors: true,
2012+
traceErrorsMessage: 'Error executing jupyter extension internal startup code',
2013+
telemetryName: Telemetry.KernelStartupCodeFailure
2014+
});
2015+
if (this.kernelConnectionMetadata.kind !== 'connectToLiveRemoteKernel') {
20162016
// Run user specified startup commands
20172017
```
20182018

build/conda-nonconda-test-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ packaging
33
# List of requirements for conda environments that cannot be installed using conda
44
livelossplot
55
versioneer
6-
pythreejs
6+
pythreejs==2.3.0
77
ipysheet
88
ipyvolume
99
beakerx

build/venv-test-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jupyter
1111
# List of requirements for conda environments that cannot be installed using conda
1212
livelossplot
1313
versioneer
14-
pythreejs
14+
pythreejs==2.3.0
1515
ipysheet
1616
ipyvolume
1717
beakerx

0 commit comments

Comments
 (0)