Skip to content

Commit be2c891

Browse files
committed
Fix IW tests
1 parent a4f967e commit be2c891

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

src/interactive-window/interactiveWindow.ts

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ import { chainWithPendingUpdates } from '../kernels/execution/notebookUpdater';
7575
import { initializeInteractiveOrNotebookTelemetryBasedOnUserAction } from '../kernels/telemetry/helper';
7676
import { generateMarkdownFromCodeLines, parseForComments } from '../platform/common/utils';
7777
import { IServiceContainer } from '../platform/ioc/types';
78-
import { KernelConnector } from '../notebooks/controllers/kernelConnector';
7978

8079
/**
8180
* ViewModel for an interactive window from the Jupyter extension's point of view.
@@ -256,6 +255,13 @@ export class InteractiveWindow implements IInteractiveWindowLoadable {
256255
await this.currentKernelInfo.kernelStarted.promise;
257256
return this.currentKernelInfo.kernel!;
258257
}
258+
const vscController = this.controllerRegistration.registered.find(
259+
(item) => item.controller.id === controller.id
260+
);
261+
if (!vscController) {
262+
// This cannot happen, but we need to make typescript happy.
263+
throw new Error('VSCController not available');
264+
}
259265
const kernelStarted = createDeferred<void>();
260266
kernelStarted.promise.catch(noop);
261267
this.currentKernelInfo = { controller, metadata, kernelStarted };
@@ -288,13 +294,9 @@ export class InteractiveWindow implements IInteractiveWindowLoadable {
288294
};
289295
// When connecting, we need to update the sys info message
290296
this.updateSysInfoMessage(this.getSysInfoMessage(metadata, SysInfoReason.Start), false, sysInfoCell);
291-
const kernel = await KernelConnector.connectToNotebookKernel(
292-
metadata,
293-
this.serviceContainer,
294-
{ resource: this.owner, notebook: this.notebookDocument, controller },
297+
const kernel = await vscController.connectToKernel(
298+
{ resource: this.owner, notebook: this.notebookDocument },
295299
new DisplayOptions(false),
296-
this.internalDisposables,
297-
'jupyterExtension',
298300
onKernelStarted,
299301
onKernelStartCompleted
300302
);

0 commit comments

Comments
 (0)