Deprecation: [@octokit/request-error] error.code is deprecated, use error.status (#6732)

* Deprecation: [@octokit/request-error] `error.code` is deprecated, use `error.status`
Fixes #6708

* Fix tests

Author: alexr00

src/common/utils.ts

@@ -142,11 +142,11 @@ function isHookError(e: Error): e is HookError {
 	return !!(e as any).errors;
 }
 
-function hasFieldErrors(e: any): e is Error & { errors: { value: string; field: string; code: string }[] } {
+function hasFieldErrors(e: any): e is Error & { errors: { value: string; field: string; status: string }[] } {
 	let areFieldErrors = true;
 	if (!!e.errors && Array.isArray(e.errors)) {
 		for (const error of e.errors) {
-			if (!error.field || !error.value || !error.code) {
+			if (!error.field || !error.value || !error.status) {
 				areFieldErrors = false;
 				break;
 			}
@@ -177,7 +177,7 @@ export function formatError(e: HookError | any): string {
 	if (e.message === 'Validation Failed' && hasFieldErrors(e)) {
 		furtherInfo = e.errors
 			.map(error => {
-				return `Value "${error.value}" cannot be set for field ${error.field} (code: ${error.code})`;
+				return `Value "${error.value}" cannot be set for field ${error.field} (code: ${error.status})`;
 			})
 			.join(', ');
 	} else if (e.message.startsWith('Validation Failed:')) {

src/github/folderRepositoryManager.ts

@@ -1205,7 +1205,7 @@ export class FolderRepositoryManager extends Disposable {
 			};
 		} catch (e) {
 			Logger.error(`Fetching pull request with query failed: ${e}`, this.id);
-			if (e.code === 404) {
+			if (e.status === 404) {
 				// not found
 				vscode.window.showWarningMessage(
 					`Fetching pull requests for remote ${githubRepository.remote.remoteName} with query failed, please check if the repo ${repo?.full_name} is valid.`,

src/github/githubRepository.ts

@@ -264,13 +264,14 @@ export class GitHubRepository extends Disposable {
 			rsp = await gql.query<T>(query);
 		} catch (e) {
 			const logInfo = (query.query.definitions[0] as { name: { value: string } | undefined }).name?.value;
-			Logger.error(`Error querying GraphQL API (${logInfo}): ${e.message}${e.graphQLErrors ? `. ${(e.graphQLErrors as GraphQLError[]).map(error => error.extensions?.code).join(',')}` : ''}`, this.id);
+			const gqlErrors = e.graphQLErrors ? e.graphQLErrors as GraphQLError[] : undefined;
+			Logger.error(`Error querying GraphQL API (${logInfo}): ${e.message}${gqlErrors ? `. ${gqlErrors.map(error => error.extensions?.code).join(',')}` : ''}`, this.id);
 			if (legacyFallback) {
 				query.query = legacyFallback.query;
 				return this.query(query, ignoreSamlErrors);
 			}
 
-			if (e.graphQLErrors && e.graphQLErrors.length && ((e.graphQLErrors as GraphQLError[]).some(error => error.extensions?.code === 'undefinedField')) && !this._areQueriesLimited) {
+			if (gqlErrors && gqlErrors.length && (gqlErrors.some(error => error.extensions?.code === 'undefinedField')) && !this._areQueriesLimited) {
 				// We're running against a GitHub server that doesn't support the query we're trying to run.
 				// Switch to the limited schema and try again.
 				this._areQueriesLimited = true;
@@ -587,7 +588,7 @@ export class GitHubRepository extends Disposable {
 			};
 		} catch (e) {
 			Logger.error(`Fetching all pull requests failed: ${e}`, this.id);
-			if (e.code === 404) {
+			if (e.status === 404) {
 				// not found
 				vscode.window.showWarningMessage(
 					`Fetching all pull requests for remote '${remote?.remoteName}' failed, please check if the repository ${remote?.owner}/${remote?.repositoryName} is valid.`,
@@ -626,7 +627,7 @@ export class GitHubRepository extends Disposable {
 			}
 		} catch (e) {
 			Logger.error(`Fetching pull request for branch failed: ${e}`, this.id);
-			if (e.code === 404) {
+			if (e.status === 404) {
 				// not found
 				vscode.window.showWarningMessage(
 					`Fetching pull request for branch for remote '${remote?.remoteName}' failed, please check if the repository ${remote?.owner}/${remote?.repositoryName} is valid.`,
@@ -891,7 +892,7 @@ export class GitHubRepository extends Disposable {
 		try {
 			Logger.debug(`Fetch authenticated user emails - enter`, this.id);
 			const { octokit } = await this.ensure();
-			const { data } = await octokit.call(octokit.api.users.listEmailsForAuthenticated, {});
+			const { data } = await octokit.call(octokit.api.users.listEmailsForAuthenticatedUser, {});
 			Logger.debug(`Fetch authenticated user emails - done`, this.id);
 			return data.map(email => email.email);
 		} catch (e) {

src/github/quickPicks.ts

@@ -349,12 +349,7 @@ export async function getMilestoneFromQuickPick(folderRepositoryManager: FolderR
 						await callback(milestone);
 					}
 				} catch (e) {
-					if (e.errors && Array.isArray(e.errors) && e.errors.find(error => error.code === 'already_exists') !== undefined) {
-						vscode.window.showErrorMessage(vscode.l10n.t('Failed to create milestone: The milestone already exists and might be closed'));
-					}
-					else {
-						vscode.window.showErrorMessage(`Failed to create milestone: ${formatError(e)}`);
-					}
+					vscode.window.showErrorMessage(`Failed to create milestone: ${formatError(e)}`);
 				}
 			});
 		});

src/test/common/utils.test.ts

@@ -42,12 +42,12 @@ describe('utils', () => {
 		});
 
 		it('should format an error with field errors', () => {
-			const error = new HookError('Validation Failed', [{ field: 'title', value: 'garbage', code: 'custom' }]);
+			const error = new HookError('Validation Failed', [{ field: 'title', value: 'garbage', status: 'custom' }]);
 			assert.strictEqual(utils.formatError(error), 'Validation Failed: Value "garbage" cannot be set for field title (code: custom)');
 		});
 
 		it('should format an error with custom ', () => {
-			const error = new HookError('Validation Failed', [{ message: 'Cannot push to this repo', code: 'custom' }]);
+			const error = new HookError('Validation Failed', [{ message: 'Cannot push to this repo', status: 'custom' }]);
 			assert.strictEqual(utils.formatError(error), 'Cannot push to this repo');
 		});
 	});