Skip to content

Commit 53fedcd

Browse files
authored
Leaving a comment shows a pending comment box with an empty input (#7201)
Fixes #7200
1 parent 525e502 commit 53fedcd

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/github/issueOverview.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ export class IssueOverviewPanel<TItem extends IssueModel = IssueModel> extends W
144144
this.pollForUpdates(this._panel.visible, true);
145145
}
146146
}));
147+
this._register({ dispose: () => clearTimeout(this.timeout) });
147148

148149
}
149150

src/github/pullRequestModel.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -457,6 +457,7 @@ export class PullRequestModel extends IssueModel<PullRequest> implements IPullRe
457457
threadWithComment.viewerCanResolve = true;
458458
this._onDidChangeReviewThreads.fire({ added: [], changed: [threadWithComment], removed: [] });
459459
}
460+
this._onDidChangeComments.fire();
460461
return reviewEvent;
461462
} else {
462463
throw new Error(`Submitting review failed, no pending review for current pull request: ${this.number}.`);
@@ -558,7 +559,6 @@ export class PullRequestModel extends IssueModel<PullRequest> implements IPullRe
558559
throw new Error('Failed to start review');
559560
}
560561
this.hasPendingReview = true;
561-
this._onDidChangeComments.fire();
562562
return data.addPullRequestReview.pullRequestReview.id;
563563
}
564564

@@ -681,6 +681,7 @@ export class PullRequestModel extends IssueModel<PullRequest> implements IPullRe
681681
this._onDidChangeReviewThreads.fire({ added: [], changed: [threadWithComment], removed: [] });
682682
}
683683

684+
this._onDidChangeComments.fire();
684685
return newComment;
685686
}
686687

0 commit comments

Comments
 (0)