Fix PR action in scm title in multi-repo (#3457)

* Clean up setting context for github:inReviewMode

* Fix PR action in scm title in multi-repo
Fixes #3410

* Remove duplicate context setting

Author: alexr00

package.json

@@ -1410,12 +1410,12 @@
 			"scm/title": [
 				{
 					"command": "review.suggestDiff",
-					"when": "scmProvider =~ /^git|^remoteHub:github/ && github:inReviewMode",
+					"when": "scmProvider =~ /^git|^remoteHub:github/ && scmProviderRootUri in github:reposInReviewMode",
 					"group": "inline"
 				},
 				{
 					"command": "pr.create",
-					"when": "scmProvider =~ /^git|^remoteHub:github/ && !github:inReviewMode",
+					"when": "scmProvider =~ /^git|^remoteHub:github/ && scmProviderRootUri in github:reposNotInReviewMode",
 					"group": "navigation"
 				}
 			],

src/common/executeCommands.ts

@@ -8,6 +8,9 @@ import * as vscode from 'vscode';
 export namespace contexts {
 	export const VIEWED_FILES = 'github:viewedFiles';
 	export const UNVIEWED_FILES = 'github:unviewedFiles';
+	export const IN_REVIEW_MODE = 'github:inReviewMode';
+	export const REPOS_NOT_IN_REVIEW_MODE = 'github:reposNotInReviewMode';
+	export const REPOS_IN_REVIEW_MODE = 'github:reposInReviewMode';
 }
 
 export namespace commands {

src/extension.ts

@@ -146,7 +146,7 @@ async function init(
 		}
 	});
 
-	const changesTree = new PullRequestChangesTreeDataProvider(context);
+	const changesTree = new PullRequestChangesTreeDataProvider(context, git, reposManager);
 	context.subscriptions.push(changesTree);
 
 	const reviewManagers = folderManagers.map(

src/view/prChangesTreeDataProvider.ts

@@ -4,10 +4,13 @@
  *--------------------------------------------------------------------------------------------*/
 
 import * as vscode from 'vscode';
+import { GitApiImpl } from '../api/api1';
+import { commands, contexts } from '../common/executeCommands';
 import Logger, { PR_TREE } from '../common/logger';
 import { FILE_LIST_LAYOUT } from '../common/settingKeys';
 import { FolderRepositoryManager, SETTINGS_NAMESPACE } from '../github/folderRepositoryManager';
 import { PullRequestModel } from '../github/pullRequestModel';
+import { RepositoriesManager } from '../github/repositoriesManager';
 import { ReviewModel } from './reviewModel';
 import { DescriptionNode } from './treeNodes/descriptionNode';
 import { GitFileChangeNode } from './treeNodes/fileChangeNode';
@@ -26,7 +29,7 @@ export class PullRequestChangesTreeDataProvider extends vscode.Disposable implem
 		return this._view;
 	}
 
-	constructor(private _context: vscode.ExtensionContext) {
+	constructor(private _context: vscode.ExtensionContext, private _git: GitApiImpl, private _reposManager: RepositoriesManager) {
 		super(() => this.dispose());
 		this._view = vscode.window.createTreeView('prStatus:github', {
 			treeDataProvider: this,
@@ -92,29 +95,41 @@ export class PullRequestChangesTreeDataProvider extends vscode.Disposable implem
 		this._pullRequestManagerMap.set(pullRequestManager, node);
 		this.updateViewTitle();
 
-		await vscode.commands.executeCommand('setContext', 'github:inReviewMode', true);
+		await this.setReviewModeContexts();
 		this._onDidChangeTreeData.fire();
 
 		if (shouldReveal) {
 			this.reveal(node);
 		}
 	}
 
+	private async setReviewModeContexts() {
+		await commands.setContext(contexts.IN_REVIEW_MODE, this._pullRequestManagerMap.size > 0);
+
+		const rootUrisNotInReviewMode: string[] = [];
+		const rootUrisInReviewMode: string[] = [];
+		this._git.repositories.forEach(repo => {
+			const folderManager = this._reposManager.getManagerForFile(repo.rootUri);
+			if (folderManager && !this._pullRequestManagerMap.has(folderManager)) {
+				rootUrisNotInReviewMode.push(repo.rootUri.toString());
+			} else if (folderManager) {
+				rootUrisInReviewMode.push(repo.rootUri.toString());
+			}
+		});
+		await commands.setContext(contexts.REPOS_NOT_IN_REVIEW_MODE, rootUrisNotInReviewMode);
+		await commands.setContext(contexts.REPOS_IN_REVIEW_MODE, rootUrisInReviewMode);
+	}
+
 	async removePrFromView(pullRequestManager: FolderRepositoryManager) {
 		const oldPR = this._pullRequestManagerMap.has(pullRequestManager) ? this._pullRequestManagerMap.get(pullRequestManager) : undefined;
 		Logger.appendLine(`Removing PR #${oldPR?.pullRequestModel.number} from tree`, PR_TREE);
 
 		oldPR?.dispose();
 		this._pullRequestManagerMap.delete(pullRequestManager);
 		this.updateViewTitle();
-		if (this._pullRequestManagerMap.size === 0) {
-			this.hide();
-		}
-		this._onDidChangeTreeData.fire();
-	}
 
-	async hide() {
-		await vscode.commands.executeCommand('setContext', 'github:inReviewMode', false);
+		await this.setReviewModeContexts();
+		this._onDidChangeTreeData.fire();
 	}
 
 	getTreeItem(element: TreeNode): vscode.TreeItem | Thenable<vscode.TreeItem> {

src/view/reviewsManager.ts

@@ -27,10 +27,10 @@ export class ReviewsManager {
 		private _prFileChangesProvider: PullRequestChangesTreeDataProvider,
 		private _telemetry: ITelemetry,
 		credentialStore: CredentialStore,
-		gitApi: GitApiImpl,
+		private _gitApi: GitApiImpl,
 	) {
 		this._disposables = [];
-		const gitContentProvider = new GitContentFileSystemProvider(gitApi, credentialStore);
+		const gitContentProvider = new GitContentFileSystemProvider(_gitApi, credentialStore);
 		gitContentProvider.registerTextDocumentContentFallback(this.provideTextDocumentContent.bind(this));
 		this._disposables.push(vscode.workspace.registerFileSystemProvider(Schemes.Review, gitContentProvider, { isReadonly: true }));
 		this.registerListeners();
@@ -43,7 +43,7 @@ export class ReviewsManager {
 				if (e.affectsConfiguration('githubPullRequests.showInSCM')) {
 					if (this._prFileChangesProvider) {
 						this._prFileChangesProvider.dispose();
-						this._prFileChangesProvider = new PullRequestChangesTreeDataProvider(this._context);
+						this._prFileChangesProvider = new PullRequestChangesTreeDataProvider(this._context, this._gitApi, this._reposManager);
 
 						for (const reviewManager of this._reviewManagers) {
 							reviewManager.updateState(true);