Add a way to get to github.com from views (#3474)

Fixes #3473

Author: alexr00

package.json

@@ -710,6 +710,12 @@
 				"category": "GitHub Pull Requests",
 				"icon": "$(edit)"
 			},
+			{
+				"command": "pr.openPullsWebsite",
+				"title": "Open on GitHub",
+				"category": "GitHub Pull Requests",
+				"icon": "$(globe)"
+			},
 			{
 				"command": "issue.createIssueFromSelection",
 				"title": "Create Issue From Selection",
@@ -847,6 +853,12 @@
 				"command": "issue.goToLinkedCode",
 				"title": "Go to Linked Code",
 				"category": "GitHub Issues"
+			},
+			{
+				"command": "issues.openIssuesWebsite",
+				"title": "Open on GitHub",
+				"category": "GitHub Pull Requests",
+				"icon": "$(globe)"
 			}
 		],
 		"viewsWelcome": [
@@ -1154,27 +1166,59 @@
 				{
 					"command": "pr.refreshActivePullRequest",
 					"when": "false"
+				},
+				{
+					"command": "pr.openPullsWebsite",
+					"when": "github:hasGitHubRemotes"
+				},
+				{
+					"command": "issues.openIssuesWebsite",
+					"when": "github:hasGitHubRemotes"
 				}
 			],
-			"view/title": [
+			"github.pullRequests.overflow": [
 				{
-					"command": "pr.create",
-					"when": "gitHubOpenRepositoryCount != 0 && github:initialized && view == pr:github",
+					"command": "pr.openPullsWebsite",
+					"when": "gitHubOpenRepositoryCount != 0 && github:initialized",
 					"group": "navigation@1"
 				},
 				{
 					"command": "pr.checkoutByNumber",
-					"when": "gitHubOpenRepositoryCount != 0 && github:initialized && view == pr:github",
+					"when": "gitHubOpenRepositoryCount != 0 && github:initialized",
 					"group": "navigation@2"
 				},
 				{
 					"command": "pr.configurePRViewlet",
-					"when": "gitHubOpenRepositoryCount != 0 && github:initialized && view =~ /(pr|issues):github/",
-					"group": "navigation@4"
+					"when": "gitHubOpenRepositoryCount != 0 && github:initialized",
+					"group": "navigation@3"
+				}
+			],
+			"github.issues.overflow": [
+				{
+					"command": "issues.openIssuesWebsite",
+					"when": "gitHubOpenRepositoryCount != 0 && github:initialized",
+					"group": "navigation@1"
+				},
+				{
+					"command": "pr.configurePRViewlet",
+					"when": "gitHubOpenRepositoryCount != 0 && github:initialized",
+					"group": "navigation@2"
+				}
+			],
+			"view/title": [
+				{
+					"command": "pr.create",
+					"when": "gitHubOpenRepositoryCount != 0 && github:initialized && view == pr:github",
+					"group": "navigation@1"
 				},
 				{
 					"command": "pr.refreshList",
 					"when": "gitHubOpenRepositoryCount != 0 && github:initialized && view == pr:github",
+					"group": "navigation@2"
+				},
+				{
+					"submenu": "github.pullRequests.overflow",
+					"when": "gitHubOpenRepositoryCount != 0 && github:initialized && view == pr:github",
 					"group": "navigation@3"
 				},
 				{
@@ -1192,15 +1236,20 @@
 					"when": "view == prStatus:github && !fileListLayout:flat",
 					"group": "navigation"
 				},
+				{
+					"command": "issue.createIssue",
+					"when": "view == issues:github && github:hasGitHubRemotes",
+					"group": "navigation@1"
+				},
 				{
 					"command": "issue.refresh",
 					"when": "view == issues:github",
 					"group": "navigation@2"
 				},
 				{
-					"command": "issue.createIssue",
-					"when": "view == issues:github && github:hasGitHubRemotes",
-					"group": "navigation@1"
+					"submenu": "github.issues.overflow",
+					"when": "gitHubOpenRepositoryCount != 0 && github:initialized && view == issues:github",
+					"group": "navigation@3"
 				},
 				{
 					"command": "pr.refreshActivePullRequest",
@@ -1558,6 +1607,18 @@
 				}
 			]
 		},
+		"submenus": [
+			{
+				"id": "github.pullRequests.overflow",
+				"label": "More actions...",
+				"icon": "$(ellipsis)"
+			},
+			{
+				"id": "github.issues.overflow",
+				"label": "More actions...",
+				"icon": "$(ellipsis)"
+			}
+		],
 		"colors": [
 			{
 				"id": "issues.newIssueDecoration",

src/commands.ts

@@ -23,7 +23,7 @@ import { GHPRComment, TemporaryComment } from './github/prComment';
 import { PullRequestModel } from './github/pullRequestModel';
 import { PullRequestOverviewPanel } from './github/pullRequestOverview';
 import { RepositoriesManager } from './github/repositoriesManager';
-import { isInCodespaces } from './github/utils';
+import { getIssuesUrl, getPullsUrl, isInCodespaces } from './github/utils';
 import { PullRequestsTreeDataProvider } from './view/prsTreeDataProvider';
 import { ReviewManager } from './view/reviewManager';
 import { CategoryTreeNode } from './view/treeNodes/categoryNode';
@@ -937,4 +937,30 @@ export function registerCommands(
 				return ReviewManager.getReviewManagerForFolderManager(reviewManagers, githubRepo.manager)?.switch(prModel);
 			}
 		}));
+
+		function chooseRepoToOpen() {
+			const githubRepositories: GitHubRepository[] = [];
+				reposManager.folderManagers.forEach(manager => {
+					githubRepositories.push(...(manager.gitHubRepositories));
+				});
+				return chooseItem<GitHubRepository>(
+					githubRepositories,
+					itemValue => `${itemValue.remote.owner}/${itemValue.remote.repositoryName}`,
+					{ placeHolder: 'Which GitHub repository do you want to open?' }
+				);
+		}
+		context.subscriptions.push(
+			vscode.commands.registerCommand('pr.openPullsWebsite', async () => {
+				const githubRepo = await chooseRepoToOpen();
+				if (githubRepo) {
+					vscode.env.openExternal(getPullsUrl(githubRepo));
+				}
+			}));
+		context.subscriptions.push(
+			vscode.commands.registerCommand('issues.openIssuesWebsite', async () => {
+				const githubRepo = await chooseRepoToOpen();
+				if (githubRepo) {
+					vscode.env.openExternal(getIssuesUrl(githubRepo));
+				}
+			}));
 }

src/github/utils.ts

@@ -989,3 +989,11 @@ export function getAvatarWithEnterpriseFallback(avatarUrl: string, email: string
 	return authProviderId === AuthProvider.github ? avatarUrl : (email ? generateGravatarUrl(
 		crypto.createHash('md5').update(email?.trim()?.toLowerCase()).digest('hex')) : undefined);
 }
+
+export function getPullsUrl(repo: GitHubRepository) {
+	return vscode.Uri.parse(`https://${repo.remote.host}/${repo.remote.owner}/${repo.remote.repositoryName}/pulls`);
+}
+
+export function getIssuesUrl(repo: GitHubRepository) {
+	return vscode.Uri.parse(`https://${repo.remote.host}/${repo.remote.owner}/${repo.remote.repositoryName}/issues`);
+}

src/issues/util.ts

@@ -11,6 +11,7 @@ import { Commit, Ref, Remote, Repository } from '../api/api';
 import { GitApiImpl } from '../api/api1';
 import { Protocol } from '../common/protocol';
 import { FolderRepositoryManager, PullRequestDefaults } from '../github/folderRepositoryManager';
+import { GitHubRepository } from '../github/githubRepository';
 import { GithubItemStateEnum, User } from '../github/interface';
 import { IssueModel } from '../github/issueModel';
 import { PullRequestModel } from '../github/pullRequestModel';
@@ -459,6 +460,30 @@ function getSimpleUpstream(repository: Repository) {
 	}
 }
 
+async function getBestPossibleUpstream(repository: Repository, commit: Commit): Promise<Remote | undefined> {
+	const fallbackUpstream = new Promise<Remote | undefined>(resolve => {
+		resolve(getSimpleUpstream(repository));
+	});
+
+	let upstream: Remote | undefined = commit ? await Promise.race([
+		getUpstream(repository, commit),
+		new Promise<Remote | undefined>(resolve => {
+			setTimeout(() => {
+				resolve(fallbackUpstream);
+			}, 1500);
+		}),
+	]) : await fallbackUpstream;
+
+	if (!upstream || !upstream.fetchUrl) {
+		// Check fallback
+		upstream = await fallbackUpstream;
+		if (!upstream || !upstream.fetchUrl) {
+			return undefined;
+		}
+	}
+	return upstream;
+}
+
 export async function createGithubPermalink(
 	gitAPI: GitApiImpl,
 	positionInfo?: NewIssue,
@@ -487,26 +512,11 @@ export async function createGithubPermalink(
 		commitHash = repository.state.HEAD?.commit;
 	}
 
-	const fallbackUpstream = new Promise<Remote | undefined>(resolve => {
-		resolve(getSimpleUpstream(repository));
-	});
-
-	let upstream: Remote | undefined = commit ? await Promise.race([
-		getUpstream(repository, commit),
-		new Promise<Remote | undefined>(resolve => {
-			setTimeout(() => {
-				resolve(fallbackUpstream);
-			}, 1500);
-		}),
-	]) : await fallbackUpstream;
-
+	const upstream = commit ? await getBestPossibleUpstream(repository, commit) : undefined;
 	if (!upstream || !upstream.fetchUrl) {
-		// Check fallback
-		upstream = await fallbackUpstream;
-		if (!upstream || !upstream.fetchUrl) {
-			return { permalink: undefined, error: 'The selection may not exist on any remote.', originalFile: uri };
-		}
+		return { permalink: undefined, error: 'The selection may not exist on any remote.', originalFile: uri };
 	}
+
 	const pathSegment = uri.path.substring(repository.rootUri.path.length);
 	const originOfFetchUrl = getUpstreamOrigin(upstream).replace(/\/$/, '');
 	return {