Add unit tests when Get-CimInstance fails

Author: ZA139

src/extension/debugger/attachQuickPick/powerShellProcessParser.ts

@@ -8,13 +8,6 @@
 import { IAttachItem, ProcessListCommand } from './types';
 
 export namespace PowerShellProcessParser {
-    // Perf numbers on Win10:
-    // | # of processes | Time (ms) |
-    // |----------------+-----------|
-    // |            309 |       413 |
-    // |            407 |       463 |
-    // |            887 |       746 |
-    // |           1308 |      1132 |
     export const powerShellCommand: ProcessListCommand = {
         command: 'powershell',
         args: [
@@ -24,6 +17,16 @@ export namespace PowerShellProcessParser {
         ], // Get-WmiObject For the legacy compatibility
     };
 
+    //for unit test with Get-WmiObject
+    export const powerShellWithoutCimCommand: ProcessListCommand = {
+        command: 'powershell',
+        args: [
+            '-Command',
+            '$processes = if (Get-Command NotExistCommand-That-Will-Never-Exist -ErrorAction SilentlyContinue) { Get-CimInstance Win32_Process } else { Get-WmiObject Win32_Process }; \
+             $processes | % { @{ name = $_.Name; commandLine = $_.CommandLine; processId = $_.ProcessId } } | ConvertTo-Json',
+        ],
+    };
+
     export function parseProcesses(processes: string): IAttachItem[] {
         const processesArray = JSON.parse(processes);
         const processEntries: IAttachItem[] = [];

src/extension/debugger/attachQuickPick/provider.ts

@@ -94,10 +94,11 @@ export class AttachProcessProvider implements IAttachProcessProvider {
         }
         const output = await plainExec(processCmd.command, processCmd.args, { throwOnStdErr: true }, customEnvVars);
         logProcess(processCmd.command, processCmd.args, { throwOnStdErr: true });
-
+        console.log(processCmd);
         if (processCmd === WmicProcessParser.wmicCommand) {
             return WmicProcessParser.parseProcesses(output.stdout);
-        } else if (processCmd === PowerShellProcessParser.powerShellCommand) {
+        } else if (processCmd === PowerShellProcessParser.powerShellCommand ||
+                   processCmd === PowerShellProcessParser.powerShellWithoutCimCommand) {
             return PowerShellProcessParser.parseProcesses(output.stdout);
         }
         return PsProcessParser.parseProcesses(output.stdout);

src/test/unittest/attachQuickPick/provider.unit.test.ts

@@ -752,5 +752,63 @@ ProcessId=8026\r
             );
             assert.deepEqual(output, expectedOutput);
         });
+
+        test('The Windows powershell Get-WmiObject process list command should be called when Get-CimInstance fails', async () => {
+            const windowsProcesses = [
+                {
+                    processId: 4,
+                    commandLine: null,
+                    name: 'System',
+                },
+                {
+                    processId: 5372,
+                    commandLine: null,
+                    name: 'svchost.exe',
+                },
+            ];
+            const expectedOutput: IAttachItem[] = [
+                {
+                    label: 'svchost.exe',
+                    description: '5372',
+                    detail: '',
+                    id: '5372',
+                    processName: 'svchost.exe',
+                    commandLine: '',
+                },
+                {
+                    label: 'System',
+                    description: '4',
+                    detail: '',
+                    id: '4',
+                    processName: 'System',
+                    commandLine: '',
+                },
+            ];
+            const foundPowerShellOutput = 'C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe\r\n';
+            
+            plainExecStub
+                .withArgs('where', ['powershell'], sinon.match.any, sinon.match.any)
+                .resolves({ stderr: '', stdout: foundPowerShellOutput });
+            
+            const windowsOutput = JSON.stringify(windowsProcesses, null, 4);
+            plainExecStub
+                .withArgs(
+                    PowerShellProcessParser.powerShellWithoutCimCommand.command,
+                    sinon.match.any,
+                    sinon.match.any,
+                    sinon.match.any,
+                )
+                .resolves({ stdout: windowsOutput });
+
+            const output = await provider.getAttachItems(PowerShellProcessParser.powerShellWithoutCimCommand);
+            sinon.assert.calledWithExactly(
+                plainExecStub.firstCall,
+                PowerShellProcessParser.powerShellWithoutCimCommand.command,
+                PowerShellProcessParser.powerShellWithoutCimCommand.args,
+                sinon.match.any,
+                sinon.match.any,
+            );
+            assert.deepEqual(output, expectedOutput);
+        });
     });
 });