dont register provider if value is false

Author: paulacamargo25

src/extension/debugger/inlineValue/pythonInlineValueProvider.ts

@@ -10,7 +10,7 @@ import {
     InlineValueVariableLookup,
     InlineValueEvaluatableExpression,
 } from 'vscode';
-import { customRequest, getConfiguration } from '../../common/vscodeapi';
+import { customRequest } from '../../common/vscodeapi';
 import { sendTelemetryEvent } from '../../telemetry';
 import { EventName } from '../../telemetry/constants';
 
@@ -20,10 +20,6 @@ export class PythonInlineValueProvider implements InlineValuesProvider {
         viewPort: Range,
         context: InlineValueContext,
     ): Promise<InlineValue[]> {
-        const showInlineValues = getConfiguration('debugpy').get<boolean>('showPythonInlineValues', false);
-        if (!showInlineValues) {
-            return [];
-        }
         let scopesRequest = await customRequest('scopes', { frameId: context.frameId });
         let variablesRequest = await customRequest('variables', {
             variablesReference: scopesRequest.scopes[0].variablesReference,

src/extension/extensionInit.ts

@@ -4,11 +4,13 @@
 'use strict';
 
 import {
+    ConfigurationChangeEvent,
     debug,
     DebugConfigurationProviderTriggerKind,
     DebugTreeItem,
     DebugVisualization,
     DebugVisualizationContext,
+    Disposable,
     languages,
     ThemeIcon,
     Uri,
@@ -200,9 +202,25 @@ export async function registerDebugger(context: IExtensionContext): Promise<IExt
         >('inlineHexDecoder', registerHexDebugVisualizationTreeProvider()),
     );
 
-    context.subscriptions.push(
-        languages.registerInlineValuesProvider({ language: 'python' }, new PythonInlineValueProvider()),
-    );
+    let registerInlineValuesProviderDisposable: Disposable;
+
+    const showInlineValues = getConfiguration('debugpy').get<boolean>('showPythonInlineValues', false);
+    if (showInlineValues) {
+        registerInlineValuesProviderDisposable = languages.registerInlineValuesProvider({ language: 'python' }, new PythonInlineValueProvider());
+        context.subscriptions.push(registerInlineValuesProviderDisposable);
+    }
+
+    context.subscriptions.push(workspace.onDidChangeConfiguration((event: ConfigurationChangeEvent) => {
+        if (event.affectsConfiguration('debugpy')) {
+            const showInlineValues = getConfiguration('debugpy').get<boolean>('showPythonInlineValues', false);
+            if (!showInlineValues) {
+                registerInlineValuesProviderDisposable.dispose();
+            } else {
+                registerInlineValuesProviderDisposable = languages.registerInlineValuesProvider({ language: 'python' }, new PythonInlineValueProvider());
+                context.subscriptions.push(registerInlineValuesProviderDisposable);
+            }
+        }
+    }));
 
     context.subscriptions.push(
         debug.registerDebugVisualizationProvider('inlineHexDecoder', {

src/test/unittest/inlineValue/pythonInlineValueProvider.unit.test.ts

@@ -514,16 +514,4 @@ suite('Debugging - pythonInlineProvider', () => {
         ];
         expect(result).to.deep.equal(expected);
     });
-
-    test("Provider should return empty array if 'showPythonInlineValues' is false", async () => {
-        getConfigurationStub.withArgs('debugpy').returns(createMoqConfiguration(false));
-        const file = path.join(WS_ROOT, 'pythonFiles', 'testAssignmentExp.py');
-        let document = await workspace.openTextDocument(file);
-        const viewPort = new Range(0, 0, 6, 0);
-        const context = { frameId: 0, stoppedLocation: new Range(3, 1, 3, 1) } as InlineValueContext;
-        const inlineValueProvider = new PythonInlineValueProvider();
-
-        const result = await inlineValueProvider.provideInlineValues(document, viewPort, context);
-        expect(result).to.deep.equal([]);
-    });
 });