Skip to content

Commit 723f297

Browse files
authored
Fix python server start with unsupported interpreter specified in extension settings (#164)
If you specify an unsupported python interpreter (version <3.7) in the extension settings, the server will start anyway, which will lead to an error.
1 parent 33b765f commit 723f297

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/extension.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,11 @@ export async function activate(context: vscode.ExtensionContext): Promise<void>
5050

5151
const runServer = async () => {
5252
const interpreter = getInterpreterFromSetting(serverId);
53-
if (interpreter && interpreter.length > 0 && checkVersion(await resolveInterpreter(interpreter))) {
54-
traceVerbose(`Using interpreter from ${serverInfo.module}.interpreter: ${interpreter.join(' ')}`);
55-
lsClient = await restartServer(serverId, serverName, outputChannel, lsClient);
53+
if (interpreter && interpreter.length > 0) {
54+
if (checkVersion(await resolveInterpreter(interpreter))) {
55+
traceVerbose(`Using interpreter from ${serverInfo.module}.interpreter: ${interpreter.join(' ')}`);
56+
lsClient = await restartServer(serverId, serverName, outputChannel, lsClient);
57+
}
5658
return;
5759
}
5860

0 commit comments

Comments
 (0)