Skip to content

Commit 1105745

Browse files
authored
Merge branch 'main' into tgrue-openai/support-activated-env-w-workspacefile
2 parents 7500871 + c7fd90a commit 1105745

40 files changed

+749
-315
lines changed

.github/actions/build-vsix/action.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,15 @@ runs:
7070
shell: bash
7171

7272
- name: Update optional extension dependencies
73-
run: npm run addExtensionPackDependencies
73+
run: |
74+
if [[ "${VSIX_NAME}" == *"insiders"* ]]; then
75+
npm run addExtensionPackDependenciesPreRelease
76+
else
77+
npm run addExtensionPackDependencies
78+
fi
7479
shell: bash
80+
env:
81+
VSIX_NAME: ${{ inputs.vsix_name }}
7582

7683
- name: Build Webpack
7784
run: |

.github/release_plan.md

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ NOTE: the number of this release is in the issue title and can be substituted in
4040
- [ ] Update `pet`:
4141
- [ ] Go to the [pet](https://github.com/microsoft/python-environment-tools) repo and check `main` and latest `release/*` branch. If there are new changes in `main` then create a branch called `release/YYYY.minor` (matching python extension release `major.minor`).
4242
- [ ] Update `build\azure-pipeline.stable.yml` to point to the latest `release/YYYY.minor` for `python-environment-tools`.
43-
- [ ] Change the version in `package.json` to the next **even** number and switch the `-dev` to `-rc`. (🤖)
43+
- [ ] Change the version in `package.json` to the next **even** number. (🤖)
4444
- [ ] Run `npm install` to make sure `package-lock.json` is up-to-date _(you should now see changes to the `package.json` and `package-lock.json` at this point which update the version number **only**)_. (🤖)
4545
- [ ] Update `ThirdPartyNotices-Repository.txt` as appropriate. You can check by looking at the [commit history](https://github.com/microsoft/vscode-python/commits/main) and scrolling through to see if there's anything listed there which might have pulled in some code directly into the repository from somewhere else. If you are still unsure you can check with the team.
4646
- [ ] Create a PR from your branch **`bump-release-[YYYY.minor]`** to `main`. Add the `"no change-log"` tag to the PR so it does not show up on the release notes before merging it.
@@ -64,7 +64,7 @@ NOTE: If there are release branches that are two versions old you can delete the
6464
### Step 4: Return `main` to dev and unfreeze (❄️ ➡ 💧)
6565
NOTE: The purpose of this step is ensuring that main always is on a dev version number for every night's 🌃 pre-release. Therefore it is imperative that you do this directly after the previous steps to reset the version in main to a dev version **before** a pre-release goes out.
6666
- [ ] Create a branch called **`bump-dev-version-YYYY.[minor+1]`**.
67-
- [ ] Bump the minor version number in the `package.json` to the next `YYYY.[minor+1]` which will be an odd number, and switch the `-rc` to `-dev`.(🤖)
67+
- [ ] Bump the minor version number in the `package.json` to the next `YYYY.[minor+1]` which will be an odd number, and add `-dev`.(🤖)
6868
- [ ] Run `npm install` to make sure `package-lock.json` is up-to-date _(you should now see changes to the `package.json` and `package-lock.json` only relating to the new version number)_ . (🤖)
6969
- [ ] Create a PR from this branch against `main` and merge it.
7070

@@ -83,12 +83,6 @@ NOTE: this PR should make all CI relating to `main` be passing again (such as th
8383
### Step 6: Take the release branch from a candidate to the finalized release
8484
- [ ] Make sure the [appropriate pull requests](https://github.com/microsoft/vscode-docs/pulls) for the [documentation](https://code.visualstudio.com/docs/python/python-tutorial) -- including the [WOW](https://code.visualstudio.com/docs/languages/python) page -- are ready.
8585
- [ ] Check to make sure any final updates to the **`release/YYYY.minor`** branch have been merged.
86-
- [ ] Create a branch against **`release/YYYY.minor`** called **`finalized-release-[YYYY.minor]`**.
87-
- [ ] Update the version in `package.json` to remove the `-rc` (🤖) from the version.
88-
- [ ] Run `npm install` to make sure `package-lock.json` is up-to-date _(the only update should be the version number if `package-lock.json` has been kept up-to-date)_. (🤖)
89-
- [ ] Update `ThirdPartyNotices-Repository.txt` manually if necessary.
90-
- [ ] Create a PR from **`finalized-release-[YYYY.minor]`** against `release/YYYY.minor` and merge it.
91-
9286

9387
### Step 7: Execute the Release
9488
- [ ] Make sure CI is passing for **`release/YYYY.minor`** release branch (🤖).

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ on:
1111
permissions: {}
1212

1313
env:
14-
NODE_VERSION: 20.18.0
14+
NODE_VERSION: 20.18.1
1515
PYTHON_VERSION: '3.10' # YML treats 3.10 the number as 3.1, so quotes around 3.10
1616
# Force a path with spaces and to test extension works in these scenarios
1717
# Unicode characters are causing 2.7 failures so skip that for now.

.github/workflows/pr-check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ on:
1010
permissions: {}
1111

1212
env:
13-
NODE_VERSION: 20.18.0
13+
NODE_VERSION: 20.18.1
1414
PYTHON_VERSION: '3.10' # YML treats 3.10 the number as 3.1, so quotes around 3.10
1515
MOCHA_REPORTER_JUNIT: true # Use the mocha-multi-reporters and send output to both console (spec) and JUnit (mocha-junit-reporter). Also enables a reporter which exits the process running the tests if it haven't already.
1616
ARTIFACT_NAME_VSIX: ms-python-insiders-vsix

.github/workflows/pr-file-check.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ jobs:
5151
if (!labels.includes('skip-issue-check')) {
5252
const prBody = context.payload.pull_request.body || '';
5353
const issueLink = prBody.match(/https:\/\/github\.com\/\S+\/issues\/\d+/);
54-
if (!issueLink) {
54+
const issueReference = prBody.match(/#\d+/);
55+
if (!issueLink && !issueReference) {
5556
core.setFailed('No associated issue found in the PR description.');
5657
}
5758
}

.github/workflows/pr-labels.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
pull-requests: write
1818
steps:
1919
- name: 'PR impact specified'
20-
uses: mheap/github-action-required-labels@388fd6af37b34cdfe5a23b37060e763217e58b03 # v5.5.0
20+
uses: mheap/github-action-required-labels@8afbe8ae6ab7647d0c9f0cfa7c2f939650d22509 # v5.5.1
2121
with:
2222
mode: exactly
2323
count: 1

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ If you encounter issues with any of the listed extensions, please file an issue
2727

2828
## Quick start
2929

30-
- **Step 1.** [Install a supported version of Python on your system](https://code.visualstudio.com/docs/python/python-tutorial#_prerequisites) (note: that the system install of Python on macOS is not supported).
30+
- **Step 1.** [Install a supported version of Python on your system](https://code.visualstudio.com/docs/python/python-tutorial#_prerequisites) (note: the system install of Python on macOS is not supported).
3131
- **Step 2.** [Install the Python extension for Visual Studio Code](https://code.visualstudio.com/docs/editor/extension-gallery).
3232
- **Step 3.** Open or create a Python file and start coding!
3333

build/azure-pipeline.pre-release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ extends:
6666
buildSteps:
6767
- task: NodeTool@0
6868
inputs:
69-
versionSpec: '20.18.0'
69+
versionSpec: '20.18.1'
7070
displayName: Select Node version
7171

7272
- task: UsePythonVersion@0
@@ -91,7 +91,7 @@ extends:
9191
- script: python ./build/update_package_file.py
9292
displayName: Update telemetry in package.json
9393

94-
- script: npm run addExtensionPackDependencies
94+
- script: npm run addExtensionPackDependenciesPreRelease
9595
displayName: Update optional extension dependencies
9696

9797
- script: npx gulp prePublishBundle

build/azure-pipeline.stable.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ extends:
6060
buildSteps:
6161
- task: NodeTool@0
6262
inputs:
63-
versionSpec: '20.18.0'
63+
versionSpec: '20.18.1'
6464
displayName: Select Node version
6565

6666
- task: UsePythonVersion@0

build/azure-pipelines/pipeline.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ extends:
3737
testPlatforms:
3838
- name: Linux
3939
nodeVersions:
40-
- 20.18.0
40+
- 20.18.1
4141
- name: MacOS
4242
nodeVersions:
43-
- 20.18.0
43+
- 20.18.1
4444
- name: Windows
4545
nodeVersions:
46-
- 20.18.0
46+
- 20.18.1
4747
testSteps:
4848
- template: /build/azure-pipelines/templates/test-steps.yml@self
4949
parameters:

0 commit comments

Comments
 (0)