refine messaging etc

Author: eleanorjboyd

src/client/testing/configuration/pytest/testConfigurationManager.ts

@@ -49,6 +49,7 @@ export class ConfigurationManager extends TestConfigurationManager {
             args.push(testDir);
         }
         const installed = await this.installer.isInstalled(Product.pytest);
+        await this.testConfigSettingsService.updateTestArgs(wkspace.fsPath, Product.pytest, args);
         if (!installed) {
             // Check if Python Environments extension is available for enhanced installation flow
             if (this.pytestInstallationHelper.isEnvExtensionAvailable()) {
@@ -64,7 +65,6 @@ export class ConfigurationManager extends TestConfigurationManager {
                 await this.installer.install(Product.pytest);
             }
         }
-        await this.testConfigSettingsService.updateTestArgs(wkspace.fsPath, Product.pytest, args);
     }
 
     private async getConfigFiles(rootDir: string): Promise<string[]> {

src/client/testing/configuration/pytestInstallationHelper.ts

@@ -44,7 +44,9 @@ export class PytestInstallationHelper {
                 return this.installPytestWithEnvExtension(workspaceUri);
             } else {
                 // Fall back to traditional installer if environments extension is not available
-                traceInfo('Python Environments extension not available, installation cannot proceed via environment extension');
+                traceInfo(
+                    'Python Environments extension not available, installation cannot proceed via environment extension',
+                );
                 return false;
             }
         } catch (error) {
@@ -66,7 +68,7 @@ export class PytestInstallationHelper {
             if (!environment) {
                 traceError('No Python environment found for workspace:', workspaceUri.fsPath);
                 await this.appShell.showErrorMessage(
-                    l10n.t('No Python environment found. Please set up a Python environment first.')
+                    l10n.t('No Python environment found. Please set up a Python environment first.'),
                 );
                 return false;
             }
@@ -77,13 +79,9 @@ export class PytestInstallationHelper {
             });
 
             traceInfo('pytest installation completed successfully');
-            await this.appShell.showInformationMessage(l10n.t('pytest has been installed successfully.'));
             return true;
         } catch (error) {
             traceError('Failed to install pytest using Python Environments extension:', error);
-            await this.appShell.showErrorMessage(
-                l10n.t('Failed to install pytest. Please install it manually or check your Python environment.')
-            );
             return false;
         }
     }
@@ -95,4 +93,4 @@ export class PytestInstallationHelper {
     isEnvExtensionAvailable(): boolean {
         return useEnvExtension();
     }
-}
+}