Skip to content

Commit 15ea008

Browse files
authored
Merge branch 'main' into dependabot/npm_and_yarn/cipher-base-1.0.6
2 parents 63f5957 + 2a41070 commit 15ea008

30 files changed

+1053
-321
lines changed

.github/actions/build-vsix/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ runs:
3232

3333
# Jedi LS depends on dataclasses which is not in the stdlib in Python 3.7.
3434
- name: Use Python 3.9 for JediLSP
35-
uses: actions/setup-python@v5
35+
uses: actions/setup-python@v6
3636
with:
3737
python-version: 3.9
3838
cache: 'pip'
@@ -93,7 +93,7 @@ runs:
9393
VSIX_NAME: ${{ inputs.vsix_name }}
9494

9595
- name: Upload VSIX
96-
uses: actions/upload-artifact@v4
96+
uses: actions/upload-artifact@v5
9797
with:
9898
name: ${{ inputs.artifact_name }}
9999
path: ${{ inputs.vsix_name }}

.github/actions/lint/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ runs:
1010
using: 'composite'
1111
steps:
1212
- name: Install Node
13-
uses: actions/setup-node@v5
13+
uses: actions/setup-node@v6
1414
with:
1515
node-version: ${{ inputs.node_version }}
1616
cache: 'npm'
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
---
2+
applyTo: '**'
3+
description: This document describes how to deal with learnings that you make. (meta instruction)
4+
---
5+
6+
This document describes how to deal with learnings that you make.
7+
It is a meta-instruction file.
8+
9+
Structure of learnings:
10+
11+
- Each instruction file has a "Learnings" section.
12+
- Each learning has a counter that indicates how often that learning was useful (initially 1).
13+
- Each learning has a 1 sentence description of the learning that is clear and concise.
14+
15+
Example:
16+
17+
```markdown
18+
## Learnings
19+
20+
- Prefer `const` over `let` whenever possible (1)
21+
- Avoid `any` type (3)
22+
```
23+
24+
When the user tells you "learn!", you should:
25+
26+
- extract a learning from the recent conversation
27+
_ identify the problem that you created
28+
_ identify why it was a problem
29+
_ identify how you were told to fix it/how the user fixed it
30+
_ generate only one learning (1 sentence) that helps to summarize the insight gained
31+
- then, add the reflected learning to the "Learnings" section of the most appropriate instruction file
32+
33+
Important: Whenever a learning was really useful, increase the counter!!
34+
When a learning was not useful and just caused more problems, decrease the counter.

.github/instructions/testing_feature_area.instructions.md

Lines changed: 187 additions & 0 deletions
Large diffs are not rendered by default.
Lines changed: 79 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
1+
---
2+
mode: edit
3+
---
4+
5+
Analyze the specified part of the VS Code Python Extension codebase to generate or update implementation instructions in `.github/instructions/<component>.instructions.md`.
6+
7+
## Task
8+
9+
Create concise developer guidance focused on:
10+
11+
### Implementation Essentials
12+
13+
- **Core patterns**: How this component is typically implemented and extended
14+
- **Key interfaces**: Essential classes, services, and APIs with usage examples
15+
- **Integration points**: How this component interacts with other extension parts
16+
- **Common tasks**: Typical development scenarios with step-by-step guidance
17+
18+
### Content Structure
19+
20+
````markdown
21+
---
22+
description: 'Implementation guide for the <component> part of the Python Extension'
23+
---
24+
25+
# <Component> Implementation Guide
26+
27+
## Overview
28+
29+
Brief description of the component's purpose and role in VS Code Python Extension.
30+
31+
## Key Concepts
32+
33+
- Main abstractions and their responsibilities
34+
- Important interfaces and base classes
35+
36+
## Common Implementation Patterns
37+
38+
### Pattern 1: [Specific Use Case]
39+
40+
```typescript
41+
// Code example showing typical implementation
42+
```
43+
````
44+
45+
### Pattern 2: [Another Use Case]
46+
47+
```typescript
48+
// Another practical example
49+
```
50+
51+
## Integration Points
52+
53+
- How this component connects to other VS Code Python Extension systems
54+
- Required services and dependencies
55+
- Extension points and contribution models
56+
57+
## Essential APIs
58+
59+
- Key methods and interfaces developers need
60+
- Common parameters and return types
61+
62+
## Gotchas and Best Practices
63+
64+
- Non-obvious behaviors to watch for
65+
- Performance considerations
66+
- Common mistakes to avoid
67+
68+
```
69+
70+
## Guidelines
71+
- **Be specific**: Use actual class names, method signatures, and file paths
72+
- **Show examples**: Include working code snippets from the codebase
73+
- **Target implementation**: Focus on how to build with/extend this component
74+
- **Keep it actionable**: Every section should help developers accomplish tasks
75+
76+
Source conventions from existing `.github/instructions/*.instructions.md`, `CONTRIBUTING.md`, and codebase patterns.
77+
78+
If `.github/instructions/<component>.instructions.md` exists, intelligently merge new insights with existing content.
79+
```
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
---
2+
mode: edit
3+
---
4+
5+
Analyze the user requested part of the codebase (use a suitable <placeholder>) to generate or update `.github/instructions/<placeholder>.instructions.md` for guiding developers and AI coding agents.
6+
7+
Focus on practical usage patterns and essential knowledge:
8+
9+
- How to use, extend, or integrate with this code area
10+
- Key architectural patterns and conventions specific to this area
11+
- Common implementation patterns with code examples
12+
- Integration points and typical interaction patterns with other components
13+
- Essential gotchas and non-obvious behaviors
14+
15+
Source existing conventions from `.github/instructions/*.instructions.md`, `CONTRIBUTING.md`, and `README.md`.
16+
17+
Guidelines:
18+
19+
- Write concise, actionable instructions using markdown structure
20+
- Document discoverable patterns with concrete examples
21+
- If `.github/instructions/<placeholder>.instructions.md` exists, merge intelligently
22+
- Target developers who need to work with or extend this code area
23+
24+
Update `.github/instructions/<placeholder>.instructions.md` with header:
25+
26+
```
27+
---
28+
description: "How to work with the <placeholder> part of the codebase"
29+
---
30+
```

.github/workflows/build.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ jobs:
130130
runs-on: ubuntu-latest
131131
steps:
132132
- name: Use Python ${{ env.PYTHON_VERSION }}
133-
uses: actions/setup-python@v5
133+
uses: actions/setup-python@v6
134134
with:
135135
python-version: ${{ env.PYTHON_VERSION }}
136136

@@ -184,7 +184,7 @@ jobs:
184184
persist-credentials: false
185185

186186
- name: Use Python ${{ matrix.python }}
187-
uses: actions/setup-python@v5
187+
uses: actions/setup-python@v6
188188
with:
189189
python-version: ${{ matrix.python }}
190190

@@ -236,7 +236,7 @@ jobs:
236236
sparse-checkout-cone-mode: false
237237

238238
- name: Install Node
239-
uses: actions/setup-node@v5
239+
uses: actions/setup-node@v6
240240
with:
241241
node-version: ${{ env.NODE_VERSION }}
242242
cache: 'npm'
@@ -252,7 +252,7 @@ jobs:
252252
run: npx @vscode/l10n-dev@latest export ./src
253253

254254
- name: Install Python ${{ matrix.python }}
255-
uses: actions/setup-python@v5
255+
uses: actions/setup-python@v6
256256
with:
257257
python-version: ${{ matrix.python }}
258258

.github/workflows/community-feedback-auto-comment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
issues: write
1313
steps:
1414
- name: Check For Existing Comment
15-
uses: peter-evans/find-comment@3eae4d37986fb5a8592848f6a574fdf654e61f9e # v3.1.0
15+
uses: peter-evans/find-comment@b30e6a3c0ed37e7c023ccd3f1db5c6c0b0c23aad # v4.0.0
1616
id: finder
1717
with:
1818
issue-number: ${{ github.event.issue.number }}

.github/workflows/gen-issue-velocity.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
persist-credentials: false
2020

2121
- name: Set up Python
22-
uses: actions/setup-python@v5
22+
uses: actions/setup-python@v6
2323
with:
2424
python-version: '3.x'
2525

.github/workflows/pr-check.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ jobs:
101101
runs-on: ubuntu-latest
102102
steps:
103103
- name: Use Python ${{ env.PYTHON_VERSION }}
104-
uses: actions/setup-python@v5
104+
uses: actions/setup-python@v6
105105
with:
106106
python-version: ${{ env.PYTHON_VERSION }}
107107

@@ -168,7 +168,7 @@ jobs:
168168
persist-credentials: false
169169

170170
- name: Use Python ${{ matrix.python }}
171-
uses: actions/setup-python@v5
171+
uses: actions/setup-python@v6
172172
with:
173173
python-version: ${{ matrix.python }}
174174

@@ -233,7 +233,7 @@ jobs:
233233
sparse-checkout-cone-mode: false
234234

235235
- name: Install Node
236-
uses: actions/setup-node@v5
236+
uses: actions/setup-node@v6
237237
with:
238238
node-version: ${{ env.NODE_VERSION }}
239239
cache: 'npm'
@@ -249,7 +249,7 @@ jobs:
249249
run: npx @vscode/l10n-dev@latest export ./src
250250

251251
- name: Use Python ${{ matrix.python }}
252-
uses: actions/setup-python@v5
252+
uses: actions/setup-python@v6
253253
with:
254254
python-version: ${{ matrix.python }}
255255

@@ -505,7 +505,7 @@ jobs:
505505
sparse-checkout-cone-mode: false
506506

507507
- name: Install Node
508-
uses: actions/setup-node@v5
508+
uses: actions/setup-node@v6
509509
with:
510510
node-version: ${{ env.NODE_VERSION }}
511511
cache: 'npm'
@@ -520,7 +520,7 @@ jobs:
520520
run: npx @vscode/l10n-dev@latest export ./src
521521

522522
- name: Use Python ${{ env.PYTHON_VERSION }}
523-
uses: actions/setup-python@v5
523+
uses: actions/setup-python@v6
524524
with:
525525
python-version: ${{ env.PYTHON_VERSION }}
526526
cache: 'pip'
@@ -680,7 +680,7 @@ jobs:
680680
run: npm run test:cover:report
681681

682682
- name: Upload HTML report
683-
uses: actions/upload-artifact@v4
683+
uses: actions/upload-artifact@v5
684684
with:
685685
name: ${{ runner.os }}-coverage-report-html
686686
path: ./coverage

0 commit comments

Comments
 (0)