Skip to content

Commit 3ac006b

Browse files
authored
clean-up stale code in testing (#25270)
1 parent 8810766 commit 3ac006b

File tree

4 files changed

+1
-42
lines changed

4 files changed

+1
-42
lines changed

src/client/testing/testController/common/argumentsHelper.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,6 @@
33

44
import { traceWarn } from '../../../logging';
55

6-
export function getOptionValues(args: string[], option: string): string[] {
7-
const values: string[] = [];
8-
let returnNextValue = false;
9-
for (const arg of args) {
10-
if (returnNextValue) {
11-
values.push(arg);
12-
returnNextValue = false;
13-
} else if (arg.startsWith(`${option}=`)) {
14-
values.push(arg.substring(`${option}=`.length));
15-
} else if (arg === option) {
16-
returnNextValue = true;
17-
}
18-
}
19-
return values;
20-
}
21-
226
export function getPositionalArguments(
237
args: string[],
248
optionsWithArguments: string[] = [],

src/client/testing/testController/pytest/runner.ts

Lines changed: 0 additions & 10 deletions
This file was deleted.

src/client/testing/testController/serviceRegistry.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,23 +4,19 @@
44
import { IExtensionSingleActivationService } from '../../activation/types';
55
import { IServiceManager } from '../../ioc/types';
66
import { PYTEST_PROVIDER, UNITTEST_PROVIDER } from '../common/constants';
7-
import { ITestFrameworkController, ITestsRunner, ITestController } from './common/types';
7+
import { ITestFrameworkController, ITestController } from './common/types';
88
import { PythonTestController } from './controller';
99
import { PytestController } from './pytest/pytestController';
10-
import { PytestRunner } from './pytest/runner';
11-
import { UnittestRunner } from './unittest/runner';
1210
import { UnittestController } from './unittest/unittestController';
1311

1412
export function registerTestControllerTypes(serviceManager: IServiceManager): void {
1513
serviceManager.addSingleton<ITestFrameworkController>(ITestFrameworkController, PytestController, PYTEST_PROVIDER);
16-
serviceManager.addSingleton<ITestsRunner>(ITestsRunner, PytestRunner, PYTEST_PROVIDER);
1714

1815
serviceManager.addSingleton<ITestFrameworkController>(
1916
ITestFrameworkController,
2017
UnittestController,
2118
UNITTEST_PROVIDER,
2219
);
23-
serviceManager.addSingleton<ITestsRunner>(ITestsRunner, UnittestRunner, UNITTEST_PROVIDER);
2420
serviceManager.addSingleton<ITestController>(ITestController, PythonTestController);
2521
serviceManager.addBinding(ITestController, IExtensionSingleActivationService);
2622
}

src/client/testing/testController/unittest/runner.ts

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)