Skip to content

Commit 3f88eed

Browse files
authored
Preparation for 2018.12.1 point release (#3708)
* Preparation for 2018.12.1 point release * Add info for failing PlatformService test on Windows CI agent * Remove use of node.os package in favour of the 'arch' package to test is64bit
1 parent 898cc23 commit 3f88eed

File tree

7 files changed

+248
-269
lines changed

7 files changed

+248
-269
lines changed

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,15 @@
11
# Changelog
22

3+
## 2018.12.1 (14 Dec 2018)
4+
5+
### Fixes
6+
7+
1. Lowering threshold for Language Server support on a platform.
8+
([#3693](https://github.com/Microsoft/vscode-python/issues/3693))
9+
1. Fix bug affecting multiple linters used in a workspace.
10+
(thanks [Ilia Novoselov](https://github.com/nullie))
11+
([#3700](https://github.com/Microsoft/vscode-python/issues/3700))
12+
313
## 2018.12.0 (13 Dec 2018)
414

515
### Thanks

ThirdPartyNotices-Distribution.txt

Lines changed: 231 additions & 259 deletions
Large diffs are not rendered by default.

news/2 Fixes/3693.md

Lines changed: 0 additions & 1 deletion
This file was deleted.

news/2 Fixes/3700.md

Lines changed: 0 additions & 2 deletions
This file was deleted.

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "python",
33
"displayName": "Python",
44
"description": "Linting, Debugging (multi-threaded, remote), Intellisense, code formatting, refactoring, unit tests, snippets, and more.",
5-
"version": "2018.12.0",
5+
"version": "2018.12.1",
66
"languageServerVersion": "0.1.72",
77
"publisher": "ms-python",
88
"author": {

src/test/common/platform/platformService.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,14 +53,14 @@ suite('PlatformService', () => {
5353
});
5454

5555
test('is64bit', async () => {
56-
let expected = true;
57-
if (os.arch() !== 'x64') {
58-
expected = false;
59-
}
56+
// tslint:disable-next-line:no-require-imports
57+
const arch = require('arch') as typeof import('arch');
58+
59+
const hostReports64Bit = arch() === 'x64';
6060
const svc = new PlatformService();
6161
const result = svc.is64bit;
6262

63-
expect(result).to.be.equal(expected, 'invalid value');
63+
expect(result).to.be.equal(hostReports64Bit, `arch() reports '${arch()}', PlatformService.is64bit reports ${result}.`);
6464
});
6565

6666
test('getVersion on Mac/Windows', async function () {

0 commit comments

Comments
 (0)