Remove winston logger dependency (#17919)

* Initial logging update

* Update logging decorators

* Update logging

* Fix dependency cycle

* Remove winston dependency

* Ensure we initialize file logging before anything

* Add news item

Author: karthiknadig

news/3 Code Health/17921.md

@@ -0,0 +1 @@
+Remove dependency on `winston` logger.

package-lock.json

@@ -1950,7 +1950,6 @@
         "vscode-languageserver-protocol": "3.16.0",
         "vscode-tas-client": "^0.1.22",
         "winreg": "^1.2.4",
-        "winston": "^3.2.1",
         "xml2js": "^0.4.19"
     },
     "devDependencies": {

package.json

@@ -9,11 +9,11 @@ import { IApplicationDiagnostics } from '../application/types';
 import { IActiveResourceService, IDocumentManager, IWorkspaceService } from '../common/application/types';
 import { PYTHON_LANGUAGE } from '../common/constants';
 import { DeprecatePythonPath } from '../common/experiments/groups';
-import { traceDecorators } from '../common/logger';
 import { IFileSystem } from '../common/platform/types';
 import { IDisposable, IExperimentService, IInterpreterPathService, Resource } from '../common/types';
 import { Deferred } from '../common/utils/async';
 import { IInterpreterAutoSelectionService } from '../interpreter/autoSelection/types';
+import { traceDecoratorError } from '../logging';
 import { sendActivationTelemetry } from '../telemetry/envFileTelemetry';
 import { IExtensionActivationManager, IExtensionActivationService, IExtensionSingleActivationService } from './types';
 
@@ -62,7 +62,7 @@ export class ExtensionActivationManager implements IExtensionActivationManager {
         ]);
     }
 
-    @traceDecorators.error('Failed to activate a workspace')
+    @traceDecoratorError('Failed to activate a workspace')
     public async activateWorkspace(resource: Resource): Promise<void> {
         const key = this.getWorkspaceKey(resource);
         if (this.activatedWorkspaces.has(key)) {