fix tests for real

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Author: kinto0

src/test/common/configSettings/configSettings.unit.test.ts

@@ -41,14 +41,15 @@ suite('Python Settings', async () => {
     let config: TypeMoq.IMock<WorkspaceConfiguration>;
     let expected: CustomPythonSettings;
     let settings: CustomPythonSettings;
+    let extensions: MockExtensions;
     setup(() => {
         sinon.stub(EnvFileTelemetry, 'sendSettingTelemetry').returns();
         config = TypeMoq.Mock.ofType<WorkspaceConfiguration>(undefined, TypeMoq.MockBehavior.Loose);
 
         const workspaceService = new WorkspaceService();
         const workspaceMemento = new MockMemento();
         const globalMemento = new MockMemento();
-        const extensions = new MockExtensions();
+        extensions = new MockExtensions();
         const persistentStateFactory = new PersistentStateFactory(globalMemento, workspaceMemento);
         expected = new CustomPythonSettings(
             undefined,
@@ -57,7 +58,7 @@ suite('Python Settings', async () => {
             new InterpreterPathService(persistentStateFactory, workspaceService, [], {
                 remoteName: undefined,
             } as IApplicationEnvironment),
-            undefined,
+            { defaultLSType: LanguageServerType.Jedi },
             extensions,
         );
         settings = new CustomPythonSettings(
@@ -67,7 +68,7 @@ suite('Python Settings', async () => {
             new InterpreterPathService(persistentStateFactory, workspaceService, [], {
                 remoteName: undefined,
             } as IApplicationEnvironment),
-            undefined,
+            { defaultLSType: LanguageServerType.Jedi },
             extensions,
         );
         expected.defaultInterpreterPath = 'python';
@@ -230,7 +231,7 @@ suite('Python Settings', async () => {
         const values = [
             { ls: LanguageServerType.Jedi, expected: LanguageServerType.Jedi, default: false },
             { ls: LanguageServerType.JediLSP, expected: LanguageServerType.Jedi, default: false },
-            { ls: LanguageServerType.Microsoft, expected: LanguageServerType.None, default: true },
+            { ls: LanguageServerType.Microsoft, expected: LanguageServerType.Jedi, default: true },
             { ls: LanguageServerType.Node, expected: LanguageServerType.Node, default: false },
             { ls: LanguageServerType.None, expected: LanguageServerType.None, default: false },
         ];
@@ -239,7 +240,48 @@ suite('Python Settings', async () => {
             testLanguageServer(v.ls, v.expected, v.default);
         });
 
-        testLanguageServer('invalid' as LanguageServerType, LanguageServerType.None, true);
+        testLanguageServer('invalid' as LanguageServerType, LanguageServerType.Jedi, true);
+    });
+
+    function testPyreflySettings(pyreflyInstalled: boolean, pyreflyDisabled: boolean, languageServerDisabled: boolean) {
+        test(`pyrefly ${pyreflyInstalled ? 'installed' : 'not installed'} and ${
+            pyreflyDisabled ? 'disabled' : 'enabled'
+        }`, () => {
+            if (pyreflyInstalled) {
+                extensions.extensionIdsToFind = ['meta.pyrefly'];
+            } else {
+                extensions.extensionIdsToFind = [];
+            }
+            config.setup((c) => c.get<boolean>('pyrefly.disableLanguageServices')).returns(() => pyreflyDisabled);
+
+            config
+                .setup((c) => c.get<string>('languageServer'))
+                .returns(() => undefined)
+                .verifiable(TypeMoq.Times.once());
+
+            settings.update(config.object);
+
+            if (languageServerDisabled) {
+                expect(settings.languageServer).to.equal(LanguageServerType.None);
+            } else {
+                expect(settings.languageServer).not.to.equal(LanguageServerType.None);
+            }
+            expect(settings.languageServerIsDefault).to.equal(true);
+            config.verifyAll();
+        });
+    }
+
+    suite('pyrefly languageServer settings', async () => {
+        const values = [
+            { pyreflyInstalled: true, pyreflyDisabled: false, languageServerDisabled: true },
+            { pyreflyInstalled: true, pyreflyDisabled: true, languageServerDisabled: false },
+            { pyreflyInstalled: false, pyreflyDisabled: true, languageServerDisabled: false },
+            { pyreflyInstalled: false, pyreflyDisabled: false, languageServerDisabled: false },
+        ];
+
+        values.forEach((v) => {
+            testPyreflySettings(v.pyreflyInstalled, v.pyreflyDisabled, v.languageServerDisabled);
+        });
     });
 
     function testExperiments(enabled: boolean) {

src/test/mocks/extension.ts

@@ -0,0 +1,16 @@
+import { injectable } from 'inversify';
+import { Extension, ExtensionKind, Uri } from 'vscode';
+
+@injectable()
+export class MockExtension<T> implements Extension<T> {
+    id!: string;
+    extensionUri!: Uri;
+    extensionPath!: string;
+    isActive!: boolean;
+    packageJSON: any;
+    extensionKind!: ExtensionKind;
+    exports!: T;
+    activate(): Thenable<T> {
+        throw new Error('Method not implemented.');
+    }
+}

src/test/mocks/extensions.ts

@@ -1,17 +1,21 @@
 import { injectable } from 'inversify';
 import { IExtensions } from '../../client/common/types';
 import { Extension, Event } from 'vscode';
+import { MockExtension } from './extension';
 
 @injectable()
 export class MockExtensions implements IExtensions {
+    extensionIdsToFind: unknown[] = [];
     all: readonly Extension<unknown>[] = [];
     onDidChange: Event<void> = () => {
         throw new Error('Method not implemented');
     };
     getExtension(extensionId: string): Extension<unknown> | undefined;
     getExtension<T>(extensionId: string): Extension<T> | undefined;
-    getExtension(_extensionId: unknown): import('vscode').Extension<unknown> | undefined {
-        throw new Error('Method not implemented.');
+    getExtension(extensionId: unknown): import('vscode').Extension<unknown> | undefined {
+        if (this.extensionIdsToFind.includes(extensionId)) {
+            return new MockExtension();
+        }
     }
     determineExtensionFromCallStack(): Promise<{ extensionId: string; displayName: string }> {
         throw new Error('Method not implemented.');