Fix any type issue that caused experiment bug to be missed (#19740)

debonte · web-flow · commit 5d8a3cb2002a · 2022-08-25T23:18:13.000-07:00
diff --git a/src/client/activation/node/analysisOptions.ts b/src/client/activation/node/analysisOptions.ts
@@ -63,8 +63,8 @@ export class NodeLanguageServerAnalysisOptions extends LanguageServerAnalysisOpt
             return true;
         }
 
-        const pylanceVersion = extensions.getExtension(PYLANCE_EXTENSION_ID)?.packageJSON.version;
-        return pylanceVersion && semver.prerelease(pylanceVersion)?.includes('dev') === true;
+        const pylanceVersion = extensions.getExtension(PYLANCE_EXTENSION_ID)?.packageJSON.version as string;
+        return pylanceVersion !== undefined && semver.prerelease(pylanceVersion)?.includes('dev') === true;
     }
 
     private getPythonSpecificEditorSection() {

Original file line number	Diff line number	Diff line change
`@@ -63,8 +63,8 @@ export class NodeLanguageServerAnalysisOptions extends LanguageServerAnalysisOpt`
`63`	`63`	`return true;`
`64`	`64`	`}`
`65`	`65`
`66`		`- const pylanceVersion = extensions.getExtension(PYLANCE_EXTENSION_ID)?.packageJSON.version;`
`67`		`- return pylanceVersion && semver.prerelease(pylanceVersion)?.includes('dev') === true;`
	`66`	`+ const pylanceVersion = extensions.getExtension(PYLANCE_EXTENSION_ID)?.packageJSON.version as string;`
	`67`	`+ return pylanceVersion !== undefined && semver.prerelease(pylanceVersion)?.includes('dev') === true;`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`private getPythonSpecificEditorSection() {`